Remove Delegate Checks Audience Validator and Prevents Null Setting of Delegate#2758
Merged
FuPingFranco merged 3 commits intodevfrom Aug 6, 2024
Merged
Conversation
FuPingFranco
changed the title
src/Microsoft.IdentityModel.Tokens/Validation/Validators.Audience.cs
Outdated
Show resolved
Hide resolved
iNinja
reviewed
Jul 31, 2024
iNinja
approved these changes
Aug 1, 2024
Contributor
iNinja
left a comment
iNinja
left a comment
There was a problem hiding this comment.
Minor change, then looks good.
src/Microsoft.IdentityModel.Tokens/Validation/Validators.Audience.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs
Outdated
Show resolved
Hide resolved
brentschmaltz
previously requested changes
Aug 1, 2024
Contributor
brentschmaltz
left a comment
brentschmaltz
left a comment
There was a problem hiding this comment.
remove 'Set' from properties that return an IList
src/Microsoft.IdentityModel.Tokens/Validation/Validators.Audience.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Validators.Audience.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Validators.Audience.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/Validators.Audience.cs
Outdated
Show resolved
Hide resolved
* Addressed PR feedback. Updated tests * Removed exception from documentation * Updated TokenType tests --------- Co-authored-by: Ignacio Inglese <[email protected]>
FuPingFranco
dismissed
brentschmaltz’s stale review
Changes have been implemented, need to dismiss review to unblock work ahead.
This was referenced Aug 6, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.13.0
statisticssweden/PxWeb#693
Closed
This was referenced Aug 15, 2025
This was referenced Nov 28, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.15.0
statisticsnorway/PxWeb#497
Closed
This was referenced Dec 8, 2025
Bump Microsoft.IdentityModel.Protocols.OpenIdConnect from 8.0.1 to 8.15.0
statisticsnorway/PxWeb#515
Closed
This was referenced Feb 9, 2026
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Delegate Checks Audience Validator and Prevents Null Setting of Delegate.
Description
TokenValidationParametersin favor of the newValidationParameters.