Add flexible VNet and subnet deployment support #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support three scenarios: new VNet, existing VNet with new subnets, existing VNet with existing subnets - Add parameters: useExistingVnet, createSubnets, vnetAddressPrefix, subnet addresses - Add update_existing_subnets nested deployment for subnet delegation updates - Remove hardcoded resource group/subscription IDs - Remove CDN-related resources
vkarasala
requested changes
Nov 5, 2025
vkarasala
reviewed
Nov 5, 2025
keshava-kandikonda
force-pushed
the
kkandikonda/vnet-subnet-flexible-deployment
branch
from
6c82611 to
7311673
Compare
vkarasala
reviewed
Nov 5, 2025
Collaborator
|
LGTM, but please add some testing evidence demonstrating the default flow and existing vnet/subnet flows. |
siriande
reviewed
Nov 7, 2025
siriande
reviewed
Nov 7, 2025
vkarasala
reviewed
Nov 7, 2025
keshava-kandikonda
force-pushed
the
kkandikonda/vnet-subnet-flexible-deployment
branch
2 times, most recently
from
01b03e6 to
8e49e1a
Compare
added 2 commits
November 11, 2025 23:41
Use reference() function to read existing subnet addressPrefix instead of omitting it. Remove unused useExistingPrivateDnsZone parameter and update documentation.
keshava-kandikonda
force-pushed
the
kkandikonda/vnet-subnet-flexible-deployment
branch
from
8e49e1a to
e089d3a
Compare
siriande
approved these changes
Nov 21, 2025
| "apiVersion": "[variables('resourceDeploymentApiVersion')]", | ||
| "condition": "[or(not(parameters('useExistingVnet')), parameters('createSubnets'))]", | ||
| "dependsOn": [ | ||
| "[resourceId('Microsoft.Network/virtualNetworks/', parameters('vnetName'))]" |
There was a problem hiding this comment.
This should wait for the VNet to be created when provisioning new VNet resource i.e., useExistingVnet is false.
| }, | ||
| { | ||
| "type": "Microsoft.Resources/deployments", | ||
| "name": "subnet_Resources", |
There was a problem hiding this comment.
The template might try to create the subnets in the Resource Group where the deployment is running. Can you verify this scenario: Use existing VNet from a different RG and create new subnet resources ?
siriande
reviewed
Nov 21, 2025
siriande
left a comment
siriande
left a comment
There was a problem hiding this comment.
Could you also add all the validated test cases in the PR description?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds flexible VNet and subnet deployment support with three scenarios:
Changes