[config] Add Initial draft of Breakout Mode subcommand by samaity · Pull Request #766 · sonic-net/sonic-utilities

samaity · 2019-12-14T20:22:02Z

Signed-off-by: Sangita Maity sangitamaity0211@gmail.com

Integrating sonicMgmt API

Signed-off-by: Sangita Maity sangitamaity0211@gmail.com

- What I did
Added breakout subcommand in config command.

admin@lnos-x1-a-fab03:~$ sudo config interface -?
Usage: config interface [OPTIONS] COMMAND [ARGS]...

  Interface-related configuration tasks

Options:
  -?, -h, --help  Show this message and exit.

Commands:
  breakout  Set interface breakout mode
  shutdown  Shut down interface
  speed     Set interface speed
  startup   Start up interface

admin@lnos-x1-a-fab03:~$ sudo config interface breakout -?
Usage: config interface breakout [OPTIONS] <interface_name> MODE

  Set interface breakout mode

Options:
  -y, --yes
  -v, --verbose   Enable verbose output
  -?, -h, --help  Show this message and exit

- How I did it
There are four basic functions needed before breakout any interface. It uses portconfig.py in sonic build image.

This Pr also has a dependency on below PRs.

sonic-buildimage #3909
sonic-utilities #765
sonic-buildimage #4960
[sonic-buildimage #4990] Enable DPB dependency check using YANG model in VS container (#45) sonic-buildimage#4990)
readJsonFile: provides platform.json output which is needed to know supported mode and port attributes.
_get_option: Provides dynamic mode option as per user argument i.e. interface name
_validate_interface_mode: Validate Parent interface and user selected mode before starting deletetion or addition process
shutdown_interfaces: shut down all the interfaces which need to be deleted.

For the integration of sonicMgmt API, this subcommand needs below three APIs.

breakout_Ports: Add Ports and default config for ports to config DB, after validation of data tree and also to delete all ports.
load_configMgmt: Load config for the commands which are capable of change in config DB

How to verify it
Verified using VS test case mentioned here

samaity@server09:~/REPO_FACTORY/GIT_REPO/DPB/sonic-buildimage/platform/vs/tests/breakout$ sudo pytest -s -v --dvsname=vs-sang test_breakout_cli.py
========================================================================================= test session starts =========================================================================================
platform linux2 -- Python 2.7.15+, pytest-3.3.0, py-1.8.0, pluggy-0.6.0 -- /usr/bin/python
cachedir: .cache
rootdir: /home/samaity/REPO_FACTORY/GIT_REPO/DPB/sonic-buildimage/platform/vs/tests/breakout, inifile:
collected 2 items

test_breakout_cli.py::TestBreakoutCli::test_InitialBreakoutMode remove extra link dummy
PASSED                                                                                      [ 50%]
test_breakout_cli.py::TestBreakoutCli::test_mode_1X100G **** Breakout Cli test Starts ****
**** 1X100G --> 2x50G passed ****
**** 2x50G --> 1x100G[40G] passed ****
**** 1X100G --> 4x25G[10G] passed ****
**** 4x25G[10G] --> 1x100G[40G] passed ****
**** 1x100G[40G] --> 2x25G(2)+1x50G(2) passed ****
**** 2x25G(2)+1x50G(2) --> 1x100G[40G] passed ****
**** 1x100G[40G] --> 1x50G(2)+2x25G(2)  passed ****
**** 1x50G(2)+2x25G(2) --> 1x100G[40G] passed ****
**** 1x100G[40G] --> 2x50G  passed ****
**** 2x50G --> 2x25G(2)+1x50G(2)  passed ****
**** 1x50G(2)+2x25G(2) --> 2x25G(2)+1x50G(2)  passed ****
**** 2x25G(2)+1x50G(2)  --> 1x100G[40G]  passed ****
PASSED                                                                                      [100%]

daall · 2020-01-29T02:48:18Z

retest this please

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com> Integrating sonicMgmt API Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

vadymhlushko-mlnx · 2020-05-06T13:33:17Z

Hi, @samaity. I had tried to integrate this PR, and also PR's (links below) that you mentioned in the "How I did it" section.
sonic-net/sonic-buildimage#3909
#765

And after that when I try to run the command:

root@r-leopard-01:/# config interface -?

I have the output like that:

Traceback (most recent call last):
File "/usr/bin/config", line 8, in <module>
from config.main import config
File "/usr/lib/python2.7/dist-packages/config/main.py", line 19, in <module>
from config_mgmt import configMgmt
File "/usr/lib/python2.7/dist-packages/config/config_mgmt.py", line 26, in <module>
raise ImportError("%s - required module not found" % str(e))
ImportError: No module named sonic_yang - required module not found

So, should I integrate something else?

samaity · 2020-05-06T15:42:49Z

Hi, @samaity. I had tried to integrate this PR, and also PR's (links below) that you mentioned in the "How I did it" section.
Azure/sonic-buildimage#3909
#765

And after that when I try to run the command:

root@r-leopard-01:/# config interface -?

I have the output like that:

Traceback (most recent call last):
File "/usr/bin/config", line 8, in <module>
from config.main import config
File "/usr/lib/python2.7/dist-packages/config/main.py", line 19, in <module>
from config_mgmt import configMgmt
File "/usr/lib/python2.7/dist-packages/config/config_mgmt.py", line 26, in <module>
raise ImportError("%s - required module not found" % str(e))
ImportError: No module named sonic_yang - required module not found

So, should I integrate something else?

@praveen-li, can you provide some info?

praveen-li · 2020-05-06T17:04:57Z

Hi, @samaity. I had tried to integrate this PR, and also PR's (links below) that you mentioned in the "How I did it" section.
Azure/sonic-buildimage#3909
#765

And after that when I try to run the command:

root@r-leopard-01:/# config interface -?

I have the output like that:

Traceback (most recent call last):
File "/usr/bin/config", line 8, in <module>
from config.main import config
File "/usr/lib/python2.7/dist-packages/config/main.py", line 19, in <module>
from config_mgmt import configMgmt
File "/usr/lib/python2.7/dist-packages/config/config_mgmt.py", line 26, in <module>
raise ImportError("%s - required module not found" % str(e))
ImportError: No module named sonic_yang - required module not found

So, should I integrate something else?

Yeah, we need PR 3861 to make it work. That PR is still in review. Thx.

vadymhlushko-mlnx · 2020-05-07T18:44:21Z

Hi, @praveen-li, I had tried to integrate PR 3861. After that I have a compilations errors that are related to sonic-yang, the issue appears when building sonic-mgmt-framework (compilation output below).

So, should I integrate something else?

praveen-li · 2020-05-07T18:57:36Z

Hi, @praveen-li, I had tried to integrate PR 3861. After that I have a compilations errors that are related to sonic-yang, the issue appears when building sonic-mgmt-framework (compilation output below).

So, should I integrate something else?

Not sure about the errors in sonic-mgmt-framework, Because sonic-yang-mgmt and sonic-mgmt-framework, should not be related. BTW, hope you are able to build sonic-yang-mgmt PKG,

jleveque · 2020-05-11T22:46:45Z

@samaity: Please fix conflicts.

vadymhlushko-mlnx · 2020-05-12T08:23:11Z

Hi, @samaity @praveen-li. I had integrated buildimage-PR3909, utilities-PR765, utilities-PR766, buildimage-PR3861. Then in sonic-buildimage/rules/config, I disabled sonic-mgmt-framework to avoid compilation errors (that I described in above comment). And after all those steps, I still have errors when I run next command on the switch:

root@r-leopard-01:/# config interface -?

Have someone of you faced such an issue, and should I integrate something else?

praveen-li · 2020-05-12T17:03:33Z

Hi, @samaity @praveen-li. I had integrated buildimage-PR3909, utilities-PR765, utilities-PR766, buildimage-PR3861. Then in sonic-buildimage/rules/config, I disabled sonic-mgmt-framework to avoid compilation errors (that I described in above comment). And after all those steps, I still have errors when I run next command on the switch:

root@r-leopard-01:/# config interface -?

Have someone of you faced such an issue, and should I integrate something else?

Kindly check if you have sonic_yang_mgmt PKG installed in pip. So "pip list | grep yang" must show sonic_yang_mgmt. Also "pip3 list | grep yang" must show sonic_yang_models.

lgtm-com · 2020-05-13T22:14:01Z

This pull request introduces 6 alerts when merging 2072a5a into 7e52ef9 - view on LGTM.com

new alerts:

3 for Unused import
2 for Variable defined multiple times
1 for Unused local variable

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

config/main.py

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

lgtm-com · 2020-05-14T00:43:35Z

This pull request introduces 1 alert when merging 8410e7d into ffd0bd1 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2020-05-21T22:29:19Z

This pull request introduces 1 alert when merging ff80160 into 221b593 - view on LGTM.com

new alerts:

1 for Unused import

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

vadymhlushko-mlnx · 2020-05-28T10:14:26Z

Hi, @samaity. Could you please tell me, approximately when do you plan to integrate sonic-buildimage-PR3909? Because there are merge conflicts that are hard to resolve properly if you are not a feature owner.

zhenggen-xu · 2020-05-29T03:53:22Z

Hi, @samaity. Could you please tell me, approximately when do you plan to integrate sonic-buildimage-PR3909? Because there are merge conflicts that are hard to resolve properly if you are not a feature owner.

We are working on the conflicts, should resolve it next week, will review the PR with MSFT next week too.

samaity · 2020-06-04T21:36:07Z

conflicts have been removed from sonic-buildimage #3909 PR and PR has been approved. Thanks!

samaity · 2020-06-29T21:59:51Z

retest this please

samaity · 2020-07-02T23:26:01Z

Retest this please

config/main.py

samaity · 2020-07-12T23:02:24Z

Retest this please

praveen-li · 2020-07-13T19:02:20Z

Okie, For Docker VS also, these PKGs[jsondiff & xmltodict] must be mentioned in dockerfile as below PRs: https://github.com/Azure/sonic-buildimage/pull/4684/files zhenggen-xu/sonic-buildimage#68 Thanks, Regards Praveen

________________________________ From: Sangita Maity <notifications@github.com> Sent: Monday, July 13, 2020 11:02 AM To: Azure/sonic-utilities <sonic-utilities@noreply.github.com> Cc: Praveen Chaudhary <pchaudhary@linkedin.com>; Mention <mention@noreply.github.com> Subject: Re: [Azure/sonic-utilities] [config] Add Initial draft of Breakout Mode subcommand (#766) @samaity commented on this pull request.

________________________________ In config/main.py<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-utilities%2Fpull%2F766%23discussion_r453832124&data=02%7C01%7Cpchaudhary%40linkedin.com%7Ce1cd737c201b480414be08d82756f7f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637302601773124713&sdata=%2FCikrLjirpT80LSt5nEqp95X%2FteCQ33YwKVS%2FUcLyOU%3D&reserved=0>:

@@ -14,7 +14,7 @@

import ipaddress from swsssdk import ConfigDBConnector, SonicV2Connector, SonicDBConfig from minigraph import parse_device_desc_xml -from config_mgmt import ConfigMgmt, ConfigMgmtDPB @praveen-li<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpraveen-li&data=02%7C01%7Cpchaudhary%40linkedin.com%7Ce1cd737c201b480414be08d82756f7f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637302601773124713&sdata=m8VfCJCCkcRnazV7rj6NeHdqCmHpGXrzRk27o323tew%3D&reserved=0>, I am seeing this error here<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsonic-jenkins.westus2.cloudapp.azure.com%2Fjob%2Fcommon%2Fjob%2Fsonic-utilities-build-pr%2F1753%2FtestReport%2Fjunit%2Ftest_crm%2FTestCrm%2Ftest_CrmIpv6Route%2F&data=02%7C01%7Cpchaudhary%40linkedin.com%7Ce1cd737c201b480414be08d82756f7f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637302601773134708&sdata=JD7h4Gf5b6wXnjMSVgHym3%2FWfJtzu8WtcBDb%2FP8OUZg%3D&reserved=0> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fsonic-utilities%2Fpull%2F766%23discussion_r453832124&data=02%7C01%7Cpchaudhary%40linkedin.com%7Ce1cd737c201b480414be08d82756f7f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637302601773134708&sdata=1b%2BG0JqmF87GceVH3PmCqNeaAMboJJ9IGHjFGBbvH%2FY%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJHZHPNWSCMVBPNPKYW5DNDR3ND4ZANCNFSM4J24O54A&data=02%7C01%7Cpchaudhary%40linkedin.com%7Ce1cd737c201b480414be08d82756f7f0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637302601773144706&sdata=7FUsjKd4FKkCUc9LGFRk3uVmdvyd%2FngtRC%2Fc0vif7Go%3D&reserved=0>.

samaity · 2020-07-13T22:59:21Z

@jleveque I have raised a PR for vs docker package dependency. Can you approve and merge the PR?
Otherwise, vs tests are getting failed due to this.

samaity · 2020-07-14T23:19:03Z

retest this please

samaity · 2020-07-15T06:34:58Z

Retest this please

…4990) Added required packages to enabled YANG dependency check for Dynamic Port Breakout in VS container. [sonic-utilities PR #766](sonic-net/sonic-utilities#766) has a dependency on it. Getting error like the following without this fix: `ImportError: No module named yang - required module not found` Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

samaity · 2020-07-21T18:57:15Z

Retest this please

zhenggen-xu · 2020-07-22T15:35:52Z

Retest this please

config/main.py

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

config/main.py

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

samaity · 2020-07-22T22:25:12Z

Retest this please

Added breakout subcommand in config command Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

6cfb3ecb0248768da0a91e5f7fb4477c5da7eb4e (HEAD -> 201911, origin/201911) [build]: allow to use extra inc/lib location to build the package (sonic-net#595) 40d34872d3b7f354adac67f084eebf6ee467f779 Merge pull request sonic-net#846 from xumia/azp-201911 76ac50f147a7d820b19d8d7628a67f2fe4f5159b Disable the build test 6c9cf655b8b5b152cab1d578e05eddf8238b81b0 Fix branch reference error ca8d81d37a9b0294098f161b036d330d9ff461e0 [ci]: download artifacts from master branch (sonic-net#768) 0cbf4d55c67a9f8f52715f95536f3588acf06c4a [ci]: use sonicbld pool (sonic-net#766) b6f1265ee9bd86f8a5e909a6f1e9b2384497c906 [ci]: add build for arm64 and armhf (sonic-net#757) 9ec0a7da64d479b124815edc5b505fb88b2532a0 CI: add azure pipeline CI/CD (sonic-net#754) 1436dbe02cd3c56f796c6b3398d4075cd05d97e0 Fix RIF issue (sonic-net#835) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

samaity marked this pull request as ready for review December 14, 2019 20:39

lguohan requested a review from jleveque December 16, 2019 20:38

samaity force-pushed the breakout_cli_msft branch from 6ff70e7 to a87bd6b Compare December 19, 2019 05:06

samaity force-pushed the breakout_cli_msft branch from a87bd6b to 8c6cefd Compare February 26, 2020 20:02

[config] Add Initial draft of Breakout Mode subcommand

4f5f45e

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com> Integrating sonicMgmt API Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

samaity force-pushed the breakout_cli_msft branch from 8c6cefd to 4f5f45e Compare March 8, 2020 00:49

zhenggen-xu mentioned this pull request Mar 9, 2020

[DPB Seastone] On boarding DPB feature to Seastone HWSKUs sonic-net/sonic-buildimage#4235

Merged

lguohan added the Port Breakout 🔱 label May 1, 2020

Merge branch 'master' into breakout_cli_msft

2072a5a

Fix LGTM issues

2646959

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

praveen-li reviewed May 13, 2020

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

config/main.py Outdated Show resolved Hide resolved

Modifying ClassName and adding Func^Con to warn user about extra tables

8410e7d

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

Merge branch 'master' into breakout_cli_msft

ff80160

Addressed review comments after discussion

2b410e6

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

Merge branch 'master' into breakout_cli_msft

33eb3a6

samaity force-pushed the breakout_cli_msft branch from 94185f1 to 5221c8f Compare June 26, 2020 22:11

vadymhlushko-mlnx reviewed Jul 10, 2020

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

samaity mentioned this pull request Jul 13, 2020

[docker-vs] Install dependencies for testing DPB sonic-net/sonic-buildimage#4960

Merged

samaity mentioned this pull request Jul 17, 2020

Enable DPB dependency check using YANG model in VS container (#45) sonic-net/sonic-buildimage#4990

Merged

samaity requested a review from jleveque July 22, 2020 18:20

jleveque suggested changes Jul 22, 2020

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

config/main.py Outdated Show resolved Hide resolved

jleveque added config Enhancement labels Jul 22, 2020

Addressed review comments

a7f55b5

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

samaity force-pushed the breakout_cli_msft branch from 7dda670 to a7f55b5 Compare July 22, 2020 18:54

jleveque suggested changes Jul 22, 2020

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

config/main.py Outdated Show resolved Hide resolved

Addressed few more review comments

16cdf4d

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

jleveque approved these changes Jul 22, 2020

View reviewed changes

jleveque merged commit aa1b072 into sonic-net:master Jul 23, 2020

samaity mentioned this pull request Jul 28, 2020

importing json needed for DPB CLI #1010

Merged

samaity mentioned this pull request Aug 15, 2020

Revert "Revert 'DPB Breakout Cli Test with proper setup (#3910)' " sonic-net/sonic-buildimage#5192

Merged

CharlieChenEC pushed a commit to CharlieChenEC/sonic-utilities that referenced this pull request May 14, 2021

[config] Add Initial draft of Breakout Mode subcommand (sonic-net#766)

6570f85

Added breakout subcommand in config command Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>

Conversation

samaity commented Dec 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daall commented Jan 29, 2020

Uh oh!

vadymhlushko-mlnx commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samaity commented May 6, 2020

Uh oh!

praveen-li commented May 6, 2020

Uh oh!

vadymhlushko-mlnx commented May 7, 2020

Uh oh!

praveen-li commented May 7, 2020

Uh oh!

jleveque commented May 11, 2020

Uh oh!

vadymhlushko-mlnx commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

praveen-li commented May 12, 2020

Uh oh!

lgtm-com bot commented May 13, 2020

Uh oh!

Uh oh!

Uh oh!

lgtm-com bot commented May 14, 2020

Uh oh!

lgtm-com bot commented May 21, 2020

Uh oh!

vadymhlushko-mlnx commented May 28, 2020

Uh oh!

zhenggen-xu commented May 29, 2020

Uh oh!

samaity commented Jun 4, 2020

Uh oh!

samaity commented Jun 29, 2020

Uh oh!

samaity commented Jul 2, 2020

Uh oh!

Uh oh!

samaity commented Jul 12, 2020

Uh oh!

praveen-li commented Jul 13, 2020 via email

Uh oh!

samaity commented Jul 13, 2020

Uh oh!

samaity commented Jul 14, 2020

Uh oh!

samaity commented Jul 15, 2020

Uh oh!

samaity commented Jul 21, 2020

Uh oh!

zhenggen-xu commented Jul 22, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samaity commented Jul 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

samaity commented Dec 14, 2019 •

edited

Loading

vadymhlushko-mlnx commented May 6, 2020 •

edited

Loading

vadymhlushko-mlnx commented May 12, 2020 •

edited

Loading