[PBH] CLI for Policy Based Hashing by vadymhlushko-mlnx · Pull Request #1701 · sonic-net/sonic-utilities

vadymhlushko-mlnx · 2021-06-29T07:17:52Z

What I did

Created click CLI plugins for PBH feature

How I did it

The CLI plugins were auto-generated (by using the sonic-cli-gen) for show and config CLI groups, then manually those were manually edited to meet PBH the CLI requirements according to the PBH HLD

How to verify it

Added the UT

Which release branch to backport (provide reason below if selected)

202106

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

…tions Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

kktheballer · 2021-07-15T00:26:24Z

tests/pbh_input/assert_show_output.py

+inner_v4_hash  inner_ip_proto
+               inner_l4_dst_port
+               inner_l4_src_port
+               inner_dst_ipv4
+               inner_src_ipv4
+inner_v6_hash  inner_ip_proto
+               inner_l4_dst_port
+               inner_l4_src_port
+               inner_dst_ipv6
+               inner_src_ipv6


If we won't have too many Hash Field Items / Name can maybe consolidate this into one row / Name

@kktheballer the question is not clear: can you please share an example for such a use case?

What I meant was that if we have too many hash field items and we make each item go into each row we may have to scroll down to view all the output.

If we will only have 4-8 hash field items per inner_v4/6_hash we could leave it as is

@kktheballer so far there will be only up to 7 hash fields. If we introduce more, than we can revisit the current CLI business logic. Are you ok with that?

Sure that sounds good @nazariig

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

…to parametrized Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

nazariig · 2021-07-22T11:33:34Z

config/plugins/pbh.py

+@click.option(
+    "--ip-mask",
+    help="""Configures IPv4/IPv6 address mask for this hash field, required when the value of --hash-field are - INNER_DST_IPV4 or
+    INNER_SRC_IPV4 or INNER_SRC_IPV4 or INNER_SRC_IPV4 """,


@vadymhlushko-mlnx please fix the description

nazariig · 2021-07-22T11:35:17Z

config/plugins/pbh.py

+)
+@click.option(
+    "--hash-field",
+    help="Configure native hash field for this hash field",


@vadymhlushko-mlnx please fix the description according to YANG model

@nazariig it is already according to the YANG model

@vadymhlushko-mlnx in YANG we have description "Configures native hash field for this hash field";

nazariig · 2021-07-22T11:39:57Z

config/plugins/pbh.py

+@click.option(
+    "--hash",
+    required=True,
+    help="Configures the hash to apply",


@vadymhlushko-mlnx please align the description with update subgroup - use YANG model as reference

@nazariig fixed

nazariig · 2021-07-22T11:41:21Z

config/plugins/pbh.py

+)
+@click.option(
+    "--ip-mask",
+    help="Configures IPv4/IPv6 address mask for this hash field",


@vadymhlushko-mlnx please align the description with add subgroup. Use YANG model as a reference

@nazariig it is already according to the YANG model

@vadymhlushko-mlnx please rework as per internal review comments

nazariig · 2021-07-22T11:43:05Z

config/plugins/pbh.py

+)
+@click.option(
+    "--priority",
+    help="Configures priority",


@vadymhlushko-mlnx please align the description with YANG model

@nazariig fixed

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

liat-grozovik · 2021-07-29T13:17:38Z

@kktheballer kindly reminder we wish to have the code merges so the test can be verified on top of it.

anshuv-mfst · 2021-08-03T15:15:37Z

hi @anish-n , @prsunny - could you please review and approve asap, this is needed in 202106 release

anish-n · 2021-08-06T16:45:31Z

@kktheballer could you please review and approve?

vadymhlushko-mlnx · 2021-08-09T06:52:22Z

@liat-grozovik could you please help to merge?

lguohan · 2021-08-23T15:52:49Z

/azp run

azure-pipelines · 2021-08-23T15:53:00Z

Azure Pipelines successfully started running 1 pipeline(s).

Ignore inner_hashing test on non-master image. The dependent change in sonic-net/sonic-utilities#1701 is not back port into 202012 branch yet. Hence ```config pbh table``` command is not supported. Signed-off-by: bingwang <bingwang@microsoft.com>

vadymhlushko-mlnx added 30 commits June 1, 2021 14:53

Fixed codestyle

559d210

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Removed YANG validation from 'config'

e20b2d0

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Generated from updated YANG model show CLI for PBH & fixed codestyle

0e44abe

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added generated config CLI for PBH

c5fe537

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Fixed codestyle for config

77754cf

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added 'pbh' subcommand & removed 'hash-field-list' subcommand

2d0167f

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Removed leaf-lists CLI commands, added example of validation click op…

5a6ea76

…tions Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added new data enums from YANG model

f94e0f0

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added show pbh ...

8dd0e7b

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added sceleton for PBH UT

3261502

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Fixed show pbh table output

bb0a710

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added 'Symmetric' field to the 'show pbh hash-field' command

6a0c248

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Fixed 'show pbh hash' output

0e20bc0

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Fixed 'show pbh rule' output

466862d

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Fixed codestyle for show CLI plugin

07000a6

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added 'show pbh statistics'

0305909

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added 'flow counter' column to 'show pbh rule'

68b07b2

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added sort, changed symmetric check, removed unused check

186ae9b

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added validation for --hash-field-list, --ip-mask

9f2b52f

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added is_exist_in_db()

b2b5472

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added is_match, interface_validator

4dca122

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Fixed codestyle

e232188

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

HOT FIX

eff1729

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Fixed issue with click callbacks

096602e

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Fixed sort output for show CLI, typo fixes

be744a0

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added few 'hash-field' tests

3739757

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Fixed issue with 'config pbh rule update'

4d005d8

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

HOTFIX for 'config pbh rule update' is_exist_in_db()

cf971b5

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added proper description for --ip-mask

e864d12

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added ip_mask & hash-field validation for ADD flow

3050212

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

vadymhlushko-mlnx added 2 commits July 14, 2021 12:22

Fixed mock db & UT for show cli

c227a73

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Rework of inject_symmetric_field()

e7970a8

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

kktheballer reviewed Jul 15, 2021

View reviewed changes

vadymhlushko-mlnx and others added 8 commits July 15, 2021 05:18

Added check for --flow-counter when displaing pbh statistics

7f208b2

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added new UT for pbh statistics

dd35eec

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added check for read pbh counters

438cea6

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Reworked sonic-clear cli group for pbh

ef680de

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Fixed help messages for config cli according to the new YANG model

9471b11

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

[pbh]: Add CLI UM.

0d28690

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

Reworked clear after of mocked DB for UT, codestyle, changes some UT …

a4709f8

…to parametrized Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Added PBH CLI user manual

a6fae69

nazariig reviewed Jul 22, 2021

View reviewed changes

Fixed description

6a19368

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

vadymhlushko-mlnx force-pushed the pbh_cli branch from 84d9b46 to 6a19368 Compare July 22, 2021 14:09

kktheballer approved these changes Aug 8, 2021

View reviewed changes

nazariig approved these changes Aug 16, 2021

View reviewed changes

liat-grozovik approved these changes Aug 23, 2021

View reviewed changes

liat-grozovik merged commit 6fd0675 into sonic-net:master Aug 25, 2021

Conversation

vadymhlushko-mlnx commented Jun 29, 2021 • edited by liat-grozovik Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nazariig Jul 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nazariig Jul 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liat-grozovik commented Jul 29, 2021

Uh oh!

anshuv-mfst commented Aug 3, 2021

Uh oh!

anish-n commented Aug 6, 2021

Uh oh!

vadymhlushko-mlnx commented Aug 9, 2021

Uh oh!

lguohan commented Aug 23, 2021

Uh oh!

azure-pipelines bot commented Aug 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vadymhlushko-mlnx commented Jun 29, 2021 •

edited by liat-grozovik

Loading

nazariig Jul 15, 2021 •

edited

Loading

nazariig Jul 22, 2021 •

edited

Loading