Merged
Conversation
This was referenced Apr 28, 2021
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
Please add UT test cases. |
Collaborator
|
Looks like this PR is work-in-progress(Draft), please change the Draft status for review to begin. |
Collaborator
Author
@venkatmahalingam done |
nazariig
force-pushed
the
master-pbh-yang
branch
2 times, most recently
from
aeec165 to
81361ec
Compare
Collaborator
Author
nazariig
commented
Jun 3, 2021
praveen-li
reviewed
Jun 3, 2021
nazariig
commented
Jun 3, 2021
Collaborator
Author
|
@anshuv-mfst the review comments are handled |
nazariig
force-pushed
the
master-pbh-yang
branch
from
c328070 to
4ed7cc3
Compare
Collaborator
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 7461 in repo Azure/sonic-buildimage |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
Signed-off-by: Nazarii Hnydyn <[email protected]>
nazariig
force-pushed
the
master-pbh-yang
branch
from
4ed7cc3 to
bc53bb6
Compare
Collaborator
Author
|
@anish-n please review & merge |
anish-n
reviewed
Jul 16, 2021
anish-n
approved these changes
Jul 16, 2021
Contributor
anish-n
left a comment
anish-n
left a comment
There was a problem hiding this comment.
High level looks good to me, I am not very familiar with Yang models, so I would recommend merging only after someone with Yang model expertise has also reviewed and signed off.
Collaborator
Author
|
@prsunny please help to merge |
prsunny
approved these changes
Jul 19, 2021
1 task
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
* [pbh]: Add YANG model. Signed-off-by: Nazarii Hnydyn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)