[202412] Add FRR failed route check in route_check.py#284
Merged
r12f merged 1 commit intoAzure:202412from Feb 16, 2026
Merged
Conversation
Cherry-pick from sonic-net/sonic-utilities PR #4119 with conflict resolution. Add detection for routes with failed state in FRR, covering both rejected and queued routes. Previously only offload flag was checked which could not detect rejected routes (offload is True for rejected routes). Changes: - Add failed_rt list to track routes with failed state - Return both missed_rt and failed_rt from check_frr_pending_routes() - Report failed FRR routes in results and syslog - Add test cases 35-38 for failed route detection
r12f
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Cherry-pick of sonic-net/sonic-utilities#4119 to 202412 branch with conflict resolution.
It supports to detect the route with offload False or without offload, which can capture queued route, because queued route doesn't have offload, but for rejected route, the offload is True. It can't detect the rejected route.
So, we add a new detection check for the value of key
failedfor route entries, which can cover both rejected and queued routes.It will help to detect rejected route and queued route on device.
How I did it
Append failed route prefix into failed list, if it's not empty, script will print error message into syslog
How to verify it
failed_FRR_routesin the failure resultsmissed_FRR_routesandfailed_FRR_routesConflict resolution notes
The 202412 branch of Azure/sonic-utilities.msft has a different code structure from sonic-net/sonic-utilities master:
get_frr_routes()instead ofget_frr_routes_parallel()results[namespace])All changes were adapted to match the 202412 branch code style.