[Counters] Query Counters Stats Capabilities#952
Merged
kcudnik merged 4 commits intosonic-net:masterfrom Oct 26, 2021
shlomibitton:shlomi_new_sai_api_query_counters_statistics_master
Merged
[Counters] Query Counters Stats Capabilities#952kcudnik merged 4 commits intosonic-net:masterfrom shlomibitton:shlomi_new_sai_api_query_counters_statistics_master
kcudnik merged 4 commits intosonic-net:masterfrom
shlomibitton:shlomi_new_sai_api_query_counters_statistics_master
Conversation
added 3 commits
September 9, 2021 11:26
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
Remove trailing white spaces
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
requested changes
Oct 4, 2021
| sai_status_t status = querySupportedBufferPoolCounters(bufferPoolId, statsMode); | ||
| if (status != SAI_STATUS_SUCCESS) | ||
| { | ||
| /* Fallback to legacy approach */ |
Collaborator
There was a problem hiding this comment.
why do we have 2 approaches?
Contributor
Author
There was a problem hiding this comment.
The legacy approach is the one we used before.
The new one is not implemented for all vendors, which means a vendor can choose to return NOT_IMPLEMENTED and keep the old way.
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Oct 5, 2021
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@kcudnik could you please help to merge? we will do the submodule update once available. |
shlomibitton
deleted the
shlomi_new_sai_api_query_counters_statistics_master
branch
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
Implement new SAI API to query counters capabilities.
This API is used to get the capabilities in a way which is not accessing the HW and performs much quicker.
New API introduced on this PR: opencomputeproject/SAI#1148
Design document:
https://github.com/Azure/SONiC/blob/master/doc/Query_Stats_Capability/Query_Stats_Capability_HLD.md