[generic_config_updater]Add empty input fixture to verify configDB before GCU tests#5506
Merged
wen587 merged 2 commits intosonic-net:masterfrom Apr 13, 2022
Merged
[generic_config_updater]Add empty input fixture to verify configDB before GCU tests#5506wen587 merged 2 commits intosonic-net:masterfrom
wen587 merged 2 commits intosonic-net:masterfrom
Conversation
wen587
changed the title
wangxin
approved these changes
Apr 13, 2022
| """Fail immediately if empty input test failure | ||
|
|
||
| Args: | ||
| duthost: Hostname of DUT. |
Collaborator
There was a problem hiding this comment.
duthost is not a hostname. It's an ansible host object that can be used to interact with the DUT device.
Contributor
There was a problem hiding this comment.
Suggest @wen587 to fix the comment in another PR.
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Add empty input fixture for GCU tests to check if current configDB is valid and GCU feature.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
During PR test, it will fail on all GCU tests if the configDB does not pass yang validation.
This empty input fixture is to verify if there is invalid config before test.
How did you do it?
Add empty input fixture.
How did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_*.py on KVM with invalid config
to see if it fail immediately.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation