Revert GCU cacl test due to random failure and add sleep in cacl for local test#5046
Merged
wen587 merged 2 commits intosonic-net:masterfrom Jan 29, 2022
Merged
Revert GCU cacl test due to random failure and add sleep in cacl for local test#5046wen587 merged 2 commits intosonic-net:masterfrom
wen587 merged 2 commits intosonic-net:masterfrom
Conversation
wen587
changed the title
qiluo-msft
changed the title
qiluo-msft
changed the title
qiluo-msft
reviewed
Jan 29, 2022
| def expect_res_success_acl_rule(duthost, expected_content_list, unexpected_content_list): | ||
| """Check if acl rule added as expected | ||
| """ | ||
| time.sleep(1) # Sleep 1 sec to ensure caclmgrd does update in case of its UPDATE_DELAY_SECS 0.5s |
Contributor
There was a problem hiding this comment.
This is a short term solution. And we need to understand if this is a feature bug. Please remove it after feature fix.
qiluo-msft
approved these changes
Jan 29, 2022
bingwang-ms
approved these changes
Jan 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Revert GCU cacl test in kvm. Add sleep in cacl for local test.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To fix nightly test GCU cacl random failure.
How did you do it?
Revert the change. Add sleep 1 sec to make sure caclmgrd does update in local test
How did you verify/test it?
Keep it out of KVM tests.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation