Merged
Conversation
Contributor
Author
|
Need Yang modification to run correctly. |
Contributor
|
sonic-net/sonic-buildimage#9724 is merged. Is it ready to review? In reply to: 1012651780 |
Contributor
Author
Yeah. It is ready for review. |
qiluo-msft
reviewed
Jan 16, 2022
| from tests.generic_config_updater.gu_utils import create_checkpoint, delete_checkpoint, rollback_or_reload | ||
|
|
||
| pytestmark = [ | ||
| pytest.mark.topology('t0'), |
Contributor
Author
There was a problem hiding this comment.
Not sure if other topos have the same init config with t0.
For example, t0 dont have AAA or TACPLUS table in configDB, so to make GCU change on that, some test need to add init config to initialize the table
Contributor
There was a problem hiding this comment.
Any topo should have the same init AAA config. Please let me know it is not.
Contributor
Author
There was a problem hiding this comment.
Apply AAA test to topo any
qiluo-msft
reviewed
Jan 16, 2022
qiluo-msft
reviewed
Jan 16, 2022
qiluo-msft
reviewed
Jan 16, 2022
qiluo-msft
reviewed
Jan 16, 2022
qiluo-msft
reviewed
Jan 17, 2022
qiluo-msft
reviewed
Jan 19, 2022
qiluo-msft
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Testcase of AAA for generic updater apply-patch
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
End to End test support for Generic Updater apply-patch
This PR is to verify the usage of 'config apply-patch' works on AAA
How did you do it?
Make some config apply change. And check if the AAA config changed as expected.
How did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_aaa.py on KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation