[202412] Fix test_acl.py [ipv6-ingress-uplink->downlink-*] cases for v6 topo#942
Merged
r12f merged 2 commits intoAzure:202412from Feb 5, 2026
Merged
Conversation
Signed-off-by: markxiao <[email protected]>
Merged
7 tasks
With extra ACL rules for V6 topo, some topos need longer timeout Signed-off-by: markxiao <[email protected]>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
t0-isolated-v6-*:
Downstream neighbors are servers connected to VLAN interface. Use DOWNSTREAM_DST_IP_VLAN as dest ips. IPv6 cases have been skipped for t0 since beginning, only fix it for v6 topos now.
t1-isolated-v6-*:
V6 topo files set ipv6_address_pattern: 2064:100:0::%02X%02X:%02X%02X:0/120.
announce_routes.py uses the pattern to generate routes for PTF and pass them to VMs. If it is not set, default pattern 20%02X:%02X%02X:0:%02X::/64 is used.
acl tests use hardcoded dest ip 20c0:a800::1 that is not covered by v6 topo pattern, so packets are forwarded with the default route to upstream VM.
Fix it by changing dest ip for v6 topos, also add acl rules for these dest ips.
With extra ACL rules for v6 topos, also increase timeout for check_rule_counters.
Manual cherry pick of sonic-net/sonic-mgmt#21760
Type of change
Back port request
Approach
What is the motivation for this PR?
test_acl.py [ipv6-ingress-uplink->downlink-*] cases failed on v6 topo
How did you do it?
Correct DOWNSTREAM_DST_IP for t0/t1-isolated-v6-*. topos, and add corresponding acl rules
How did you verify/test it?
Test passed on t0/t1-isolated-v6-*. topos
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation