Skip to content

[cherry-pick] Add multi-asic support to test_pktgen.py #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yejianquan merged 1 commit into from
Oct 14, 2025
Merged

[cherry-pick] Add multi-asic support to test_pktgen.py #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1935,13 +1935,6 @@ telemetry/test_telemetry.py::test_telemetry_queue_buffer_cnt:
- "topo_type in ['m0', 'mx']"
- "(is_multi_asic==True) and https://github.com/sonic-net/sonic-mgmt/issues/15393"

#######################################
Copy link

@yejianquan yejianquan Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double confirm, have we tried to run the test on our lab testbed? Have it passed?

Copy link
Author

@augusdn augusdn Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, here is elastic testplan link with test result using 202405-chassis branch on tk5 testbed
https://elastictest.org/scheduler/testplan/68da3e0f94c3b56043447aad

##### pktgen #####
#######################################
test_pktgen.py:
skip:
reason: "have known issue, skip for now"

#######################################
##### vs_chassis #####
#######################################
Expand Down
46 changes: 28 additions & 18 deletions tests/test_pktgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,25 @@

CLEANUP_CMDS = [
"modprobe pktgen",
"echo 'reset' > /proc/net/pktgen/pgctrl",
"echo 'rem_device_all' > /proc/net/pktgen/kpktgend_0"
]

CLEANUP_ASIC_CMDS = [
"sh -c \"echo 'reset' > /proc/net/pktgen/pgctrl\"",
"sh -c \"echo 'rem_device_all' > /proc/net/pktgen/kpktgend_0\""
]

PKTGEN_CMDS = [
"echo 'add_device {}' > /proc/net/pktgen/kpktgend_0",
"echo 'count 15000' > /proc/net/pktgen/{}",
"echo 'pkt_size 1460' > /proc/net/pktgen/{}",
"echo 'src_min 10.10.1.2' > /proc/net/pktgen/{}",
"echo 'dst_min 10.10.1.3' > /proc/net/pktgen/{}",
"echo 'src_mac {}' > /proc/net/pktgen/{}",
"echo 'dst_mac 00:06:07:08:09:00' > /proc/net/pktgen/{}",
"echo 'udp_src_min 5000' > /proc/net/pktgen/{}",
"echo 'udp_src_max 5000' > /proc/net/pktgen/{}",
"echo 'udp_dst_min 5001' > /proc/net/pktgen/{}",
"echo 'udp_dst_max 5001' > /proc/net/pktgen/{}",
"sh -c \"echo 'add_device {}' > /proc/net/pktgen/kpktgend_0\"",
"sh -c \"echo 'count 15000' > /proc/net/pktgen/{}\"",
"sh -c \"echo 'pkt_size 1460' > /proc/net/pktgen/{}\"",
"sh -c \"echo 'src_min 10.10.1.2' > /proc/net/pktgen/{}\"",
"sh -c \"echo 'dst_min 10.10.1.3' > /proc/net/pktgen/{}\"",
"sh -c \"echo 'src_mac {}' > /proc/net/pktgen/{}\"",
"sh -c \"echo 'dst_mac 00:06:07:08:09:00' > /proc/net/pktgen/{}\"",
"sh -c \"echo 'udp_src_min 5000' > /proc/net/pktgen/{}\"",
"sh -c \"echo 'udp_src_max 5000' > /proc/net/pktgen/{}\"",
"sh -c \"echo 'udp_dst_min 5001' > /proc/net/pktgen/{}\"",
"sh -c \"echo 'udp_dst_max 5001' > /proc/net/pktgen/{}\"",
]


Expand All @@ -48,15 +51,21 @@ def clear_pktgen(duthosts, enum_dut_hostname):
duthost = duthosts[enum_dut_hostname]
for cmd in CLEANUP_CMDS:
duthost.shell(cmd)
for asichost in duthost.asics:
for cmd in CLEANUP_ASIC_CMDS:
asichost.command(cmd)
duthost.shell("sonic-clear counters")

yield

for cmd in CLEANUP_CMDS:
duthost.shell(cmd)
for asichost in duthost.asics:
for cmd in CLEANUP_ASIC_CMDS:
asichost.command(cmd)


def test_pktgen(duthosts, enum_dut_hostname, enum_frontend_asic_index, tbinfo, loganalyzer, setup_thresholds):
def test_pktgen(duthosts, enum_dut_hostname, enum_frontend_asic_index, tbinfo, loganalyzer):
'''
Testcase does the following steps:
1. Check max CPU utilized , number of core and dump files before starting the run
Expand All @@ -78,24 +87,25 @@ def test_pktgen(duthosts, enum_dut_hostname, enum_frontend_asic_index, tbinfo, l
# Select a random port to run traffic
port_list = get_port_list(duthost, tbinfo)
port = random.choice(port_list)
asichost = duthost.get_port_asic_instance(port)

# Populate packet details
for cmd in PKTGEN_CMDS:
if "src_mac" in cmd:
duthost.shell(cmd.format(router_mac, port))
asichost.command(cmd.format(router_mac, port))
else:
duthost.shell(cmd.format(port))
asichost.command(cmd.format(port))

try:
loganalyzer.ignore_regex.extend(ignoreRegex)
with loganalyzer:
# Send packet
duthost.shell("sudo echo 'start' > /proc/net/pktgen/pgctrl")
asichost.command("sh -c \"sudo echo 'start' > /proc/net/pktgen/pgctrl\"")
except LogAnalyzerError as err:
raise err

# Verify packet count from pktgen
pktgen_param = duthost.shell("cat /proc/net/pktgen/{}".format(port))["stdout"]
pktgen_param = asichost.command("cat /proc/net/pktgen/{}".format(port))["stdout"]
pktgen_param = pktgen_param.split("\n")[0]
pytest_assert(int(re.match(r".*count\s(\d+)", pktgen_param).group(1)) == 15000,
"Mismatch between number of packets intended to be generated and number of packets generated")
Expand Down