Skip to content

Added Prestep to change counterpoll port interval to 2000 in golden config#723

Merged
r12f merged 2 commits intoAzure:202412from
AharonMalkin:counterpoll_fix
Oct 9, 2025
Merged

Added Prestep to change counterpoll port interval to 2000 in golden config#723
r12f merged 2 commits intoAzure:202412from
AharonMalkin:counterpoll_fix

Conversation

@AharonMalkin
Copy link

Description of PR

Summary:
Added a step to update the counterpoll port interval to 2000 as agreed, to imporve slowness observed in nexthop group and member programming

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Improve slowness of nexthop group and member programming

How did you do it?

Added a step in the golden config generation script to change the counterpoll port interval to 2000.

How did you verify/test it?

Ran deploy flow and verified configuration is applied on golden config json and in redis db.

Any platform specific information?

SN5600/5640

Supported testbed topology if it's a new test case?

Documentation

@AharonMalkin AharonMalkin changed the title Change counterpoll port interval Added Prestep to change counterpoll port interval to 2000 in golden config Sep 22, 2025
@r12f
Copy link
Contributor

r12f commented Oct 2, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AharonMalkin
Copy link
Author

/azpw run

@r12f
Copy link
Contributor

r12f commented Oct 6, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@r12f r12f merged commit 6f02173 into Azure:202412 Oct 9, 2025
14 checks passed
@sdszhang
Copy link

@AharonMalkin we are seeing regression with the following error:

importlib._bootstrap>\\", line 621, in _exec\\n  File \\"<frozen importlib._bootstrap_external>\\", line 940, in 
exec_module\\n  File \\"<frozen importlib._bootstrap>\\", line 241, in _call_with_frames_removed\\n  File 
\\"/tmp/ansible_generate_golden_config_db_payload_9x6dtuml/__main__.py\\", line 341, in <module>\\n  File 
\\"/tmp/ansible_generate_golden_config_db_payload_9x6dtuml/__main__.py\\", line 337, in main\\n  File 
\\"/tmp/ansible_generate_golden_config_db_payload_9x6dtuml/__main__.py\\", line 324, in generate\\n  File 
\\"/tmp/ansible_generate_golden_config_db_payload_9x6dtuml/__main__.py\\", line 135, in 
generate_full_lossy_golden_config_db\\nKeyError: 'PORT'\\n",

@AharonMalkin
Copy link
Author

@AharonMalkin we are seeing regression with the following error:

importlib._bootstrap>\\", line 621, in _exec\\n  File \\"<frozen importlib._bootstrap_external>\\", line 940, in 
exec_module\\n  File \\"<frozen importlib._bootstrap>\\", line 241, in _call_with_frames_removed\\n  File 
\\"/tmp/ansible_generate_golden_config_db_payload_9x6dtuml/__main__.py\\", line 341, in <module>\\n  File 
\\"/tmp/ansible_generate_golden_config_db_payload_9x6dtuml/__main__.py\\", line 337, in main\\n  File 
\\"/tmp/ansible_generate_golden_config_db_payload_9x6dtuml/__main__.py\\", line 324, in generate\\n  File 
\\"/tmp/ansible_generate_golden_config_db_payload_9x6dtuml/__main__.py\\", line 135, in 
generate_full_lossy_golden_config_db\\nKeyError: 'PORT'\\n",

Hey @sdszhang , This is unexpected that the golden config db does not include PORT key in the flex counter table.
On our side the original golden config does include it.
However, to fix the issue on your side I submitted the following PR : #760
Please review and take it to overcome the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants