Skip to content

[action] [PR:16834] Replace ExaBGP v3 and v4 flask based process API with tornado#630

Merged
mssonicbld merged 1 commit intoAzure:202412from
mssonicbld:cherry/msft-202412/16834
Aug 7, 2025
Merged

[action] [PR:16834] Replace ExaBGP v3 and v4 flask based process API with tornado#630
mssonicbld merged 1 commit intoAzure:202412from
mssonicbld:cherry/msft-202412/16834

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Replace the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.

Merge after sonic-net/sonic-buildimage#21655

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Replace the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.

How did you do it?

Replace ExaBGP process API with Tornado app.

How did you verify/test it?

Ran add, remove topology to check announce routes
Ran route stress test to verify it is stable

Any platform specific information?

None

Supported testbed topology if it's a new test case?

NA

Documentation

NA

### Description of PR

Replace the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.

**Merge after sonic-net/sonic-buildimage#21655

Summary:
Fixes # (issue)

### Type of change

- [x] Bug fix
- [x] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?

Replace the Flask based ExaBGP process API with tornado-based application. Tornado handles large number of requests with higher payload sizes automatically while Flask+Werkzeug requires additional setting changes which can be avoided keeping the code cleaner.

#### How did you do it?

Replace ExaBGP process API with Tornado app.

#### How did you verify/test it?

Ran add, remove topology to check announce routes
Ran route stress test to verify it is stable

#### Any platform specific information?

None

#### Supported testbed topology if it's a new test case?

NA

### Documentation

NA
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: sonic-net/sonic-mgmt#16834

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit da10a6d into Azure:202412 Aug 7, 2025
6 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant