[202503][PR:23107] Enable link training support in sonic-mgmt#1077
Merged
bingwang-ms merged 4 commits intoAzure:202503from Mar 24, 2026
Merged
[202503][PR:23107] Enable link training support in sonic-mgmt#1077bingwang-ms merged 4 commits intoAzure:202503from
bingwang-ms merged 4 commits intoAzure:202503from
Conversation
Signed-off-by: Dashuai Zhang <[email protected]>
Signed-off-by: Dashuai Zhang <[email protected]>
There was a problem hiding this comment.
Pull request overview
Cherry-picks upstream changes to enable link-training support in the SONiC mgmt tooling, primarily by propagating link-training intent from the connection graph into generated fanout configs and by generating a topo-specific golden config override for t0-f2.
Changes:
- Extend fanout SONiC deploy template to emit
link_training(and enhanced FEC/autoneg handling) based ondevice_connlink metadata. - Add
generate_t0_f2_golden_config_db()to enablelink_trainingon server-facing ports for supported t0-f2 topology. - Parse
LinkTrainingfrom connection graph link records intodevice_connfacts.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ansible/roles/fanout/templates/sonic_deploy_202405.j2 | Emits per-port link_training/autoneg/FEC settings into the fanout base config JSON. |
| ansible/library/generate_golden_config_db.py | Generates topo-specific golden config enabling link_training on server-facing ports for t0-f2. |
| ansible/library/conn_graph_facts.py | Adds parsing/propagation of LinkTraining link metadata into device_conn. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: Dashuai Zhang <[email protected]>
bingwang-ms
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick sonic-net/sonic-mgmt#23107 into 202503.
Description of PR
Summary:
Enable link-training support in sonic-mgmt
Currently, enabling them for all server facing ports in F2 T0 topo. Once we have port-channel support, we can enable them only for port-channel in F2 topo.
Type of change
Back port request
Approach
What is the motivation for this PR?
Enable link-training support in sonic-mgmt
How did you do it?
Enabling link training in golden_config_db for F2 topology.
How did you verify/test it?
local testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation