[build] SONiC platform daemons depend on swsscommon library#5922
[build] SONiC platform daemons depend on swsscommon library#5922jleveque merged 2 commits intosonic-net:masterfrom jleveque:plat_daemons_swsscommon
Conversation
|
@qiluo-msft: Check builds are failing because mock swsscommon calls appear to be unimplemented. Have you seen this before? |
|
I guess it is related to this part of dynamic behavior in test It is not recommended practice. It assumes swsscommon is missing in unit test environment. In reply to: 727131567 [](ancestors = 727131567) |
Good find! Thanks, Qi! I believe this was recently exposed because sonic-utilities recently started depending on swsscommon, which caused to to get installed in the build environment earlier than previously. I have opened a PR which should fix this: sonic-net/sonic-platform-daemons#112 |
|
retest this please |
…t#5922) Add dependencies in appropriate makefiles to ensure proper build/installation of SONiC platform daemons (ledd, psud, syseepromd, thermalctld, xcvrd).
- Why I did it
To ensure proper build/installation of SONiC platform daemons (ledd, psud, syseepromd, thermalctld, xcvrd).
- How I did it
Add dependencies in appropriate makefiles
- How to verify it
- Which release branch to backport (provide reason below if selected)