Skip to content

[as4630-54pe]Modify to read correct psu SN and ID#5389

Merged
lguohan merged 24 commits intosonic-net:masterfrom
jostar-yang:as4630-54pe_20200916_psu_id
Jul 24, 2021
Merged

[as4630-54pe]Modify to read correct psu SN and ID#5389
lguohan merged 24 commits intosonic-net:masterfrom
jostar-yang:as4630-54pe_20200916_psu_id

Conversation

@jostar-yang
Copy link
Copy Markdown
Contributor

@jostar-yang jostar-yang commented Sep 16, 2020 •
edited by lguohan
Loading

- Why I did it
The PSU is specific. Get SN and ID is not meet with standard method.
Old code

# cat psu_serial_number
SB020X18195100004
(It lack the last one byte. It should be SB020X181951000046 )
as4630-54pe-2:/sys/bus/i2c/drivers/as4630_54pe_psu/11-0051# cat psu_model_name
YPEB1200?AM-1A03P10 ( It should beYPEB1200?AM )

- How I did it
Modift psu drv to get and parse/shift need offset to get correct data
- How to verify it
New Code

# cat psu_serial_number
SB020X181951000046

4630-54pe-2:/sys/bus/i2c/drivers/as4630_54pe_psu/11-0051# cat psu_serial_number
SB020X181951000047


as4630-54pe-2:/sys/bus/i2c/drivers/as4630_54pe_psu/11-0051# cat psu_model_name
YPEB1200AM
as4630-54pe-2:/sys/bus/i2c/drivers/as4630_54pe_psu/11-0051#
as4630-54pe-2:/sys/bus/i2c/drivers/as4630_54pe_psu/11-0051#
4630-54pe-2:/sys/bus/i2c/drivers/as4630_54pe_psu/11-0051# cat psu_serial_name
SB020X181951000047
as4630-54pe-2:/sys/bus/i2c/drivers/as4630_54pe_psu/10-0050# cat psu_model_name
YPEB1200AM

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

jostar-yang added 18 commits June 12, 2019 17:42
@jostar-yang
Add support as9716 platform
e0870a7
@jostar-yang
Merge branch 'master' of https://github.com/jostar-yang/sonic-buildimage
b580e8a
@jostar-yang
remove as9716
7973485
@jostar-yang
remove as9716 needed mk
78f4fc3
@jostar-yang
Merge branch 'master' of https://github.com/Azure/sonic-buildimage
8a6c679
@jostar-yang
Merge branch 'master' of https://github.com/Azure/sonic-buildimage
f7826e3
@jostar-yang
Add to support as9716 platform
94006a5
@jostar-yang
Add support build as9716 platform to mk file
a893a68
@jostar-yang
Add support AS5835_54T platform
4c21d0a
@jostar-yang
Merge branch 'master' of https://github.com/Azure/sonic-buildimage
f3220df
@jostar-yang
Merge branch 'master' of https://github.com/Azure/sonic-buildimage
2e2b8ac
@jostar-yang
Merge branch 'master' of https://github.com/Azure/sonic-buildimage
c517556
@jostar-yang
Merge branch 'master' of https://github.com/Azure/sonic-buildimage
5ded80f
@jostar-yang
Merge branch 'master' of https://github.com/Azure/sonic-buildimage
e9aba06
@jostar-yang
Merge branch 'master' of https://github.com/Azure/sonic-buildimage
c148f54
@jostar-yang
Merge branch 'master' of https://github.com/Azure/sonic-buildimage
fa793e0
@jostar-yang
Merge branch 'master' of https://github.com/Azure/sonic-buildimage
48a537c
@jostar-yang
Merge branch 'master' of https://github.com/Azure/sonic-buildimage
531f583
@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented Sep 17, 2020

Retest mellanox please

@jleveque
Copy link
Copy Markdown
Contributor

jleveque commented Sep 17, 2020

Retest vsimage please

jleveque
jleveque previously approved these changes Sep 17, 2020
View reviewed changes
@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Sep 27, 2020

Retest vsimage please

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Sep 27, 2020

Retest mellanox please

@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Jan 25, 2021

/AzurePipeline run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 25, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@jostar-yang
Copy link
Copy Markdown
Contributor Author

jostar-yang commented Jan 29, 2021

Retest vsimage please

@jostar-yang jostar-yang requested a review from lguohan as a code owner February 6, 2021 20:29
@jostar-yang jostar-yang force-pushed the as4630-54pe_20200916_psu_id branch from 179f585 to 630d9de Compare April 12, 2021 03:09
@jostar-yang
Copy link
Copy Markdown
Contributor Author

jostar-yang commented Jul 8, 2021 •
edited
Loading

@lguohan
Can you help merge code?　This PR pass all checking for a long time.

@seanwu-ec seanwu-ec mentioned this pull request Jul 14, 2021
Closed
5 tasks
@lguohan lguohan merged commit 24cc827 into sonic-net:master Jul 24, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@jostar-yang
[as4630-54pe] Modify to read correct psu SN and ID (sonic-net#5389)
5e10094 
Co-authored-by: Jostar Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

+1 more reviewer

@jleveque jleveque jleveque left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug 🐛 Platform: Accton

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jostar-yang @jleveque @lguohan