[Mellanox]the port index in port_config.ini should starts from 0 by stephenxs · Pull Request #4152 · sonic-net/sonic-buildimage

stephenxs · 2020-02-14T09:57:12Z

- What I did
The port index in port_config.ini should starts from 0, otherwise it will cause xcvrd crash.

Feb 11 21:06:01.716349 arc-switch1004 INFO pmon#supervisord: xcvrd SFP index 32 out of range (0-31)
Feb 11 21:06:01.716613 arc-switch1004 INFO pmon#supervisord: xcvrd Traceback (most recent call last):
Feb 11 21:06:01.716720 arc-switch1004 INFO pmon#supervisord: xcvrd   File "/usr/bin/xcvrd", line 1083, in <module>
Feb 11 21:06:01.716805 arc-switch1004 INFO pmon#supervisord: xcvrd     main()
Feb 11 21:06:01.716886 arc-switch1004 INFO pmon#supervisord: xcvrd   File "/usr/bin/xcvrd", line 1080, in main
Feb 11 21:06:01.716963 arc-switch1004 INFO pmon#supervisord: xcvrd     xcvrd.run()
Feb 11 21:06:01.717039 arc-switch1004 INFO pmon#supervisord: xcvrd   File "/usr/bin/xcvrd", line 1044, in run
Feb 11 21:06:01.717116 arc-switch1004 INFO pmon#supervisord: xcvrd     self.init()
Feb 11 21:06:01.717191 arc-switch1004 INFO pmon#supervisord: xcvrd   File "/usr/bin/xcvrd", line 1028, in init
Feb 11 21:06:01.717266 arc-switch1004 INFO pmon#supervisord: xcvrd     post_port_sfp_dom_info_to_db(is_warm_start, self.stop_event)
Feb 11 21:06:01.717343 arc-switch1004 INFO pmon#supervisord: xcvrd   File "/usr/bin/xcvrd", line 387, in post_port_sfp_dom_info_to_db
Feb 11 21:06:01.717421 arc-switch1004 INFO pmon#supervisord: xcvrd     post_port_sfp_info_to_db(logical_port_name, int_tbl, transceiver_dict, stop_event)
Feb 11 21:06:01.717498 arc-switch1004 INFO pmon#supervisord: xcvrd   File "/usr/bin/xcvrd", line 223, in post_port_sfp_info_to_db
Feb 11 21:06:01.717573 arc-switch1004 INFO pmon#supervisord: xcvrd     if not _wrapper_get_presence(physical_port):
Feb 11 21:06:01.717665 arc-switch1004 INFO pmon#supervisord: xcvrd   File "/usr/bin/xcvrd", line 123, in _wrapper_get_presence
Feb 11 21:06:01.717740 arc-switch1004 INFO pmon#supervisord: xcvrd     return platform_chassis.get_sfp(physical_port).get_presence()
Feb 11 21:06:01.717815 arc-switch1004 INFO pmon#supervisord: xcvrd AttributeError: 'NoneType' object has no attribute 'get_presence'

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/port_config.ini

zhenggen-xu · 2020-02-14T19:35:18Z

What is the definition of the index here? I saw most of the implementation was "front pannel" port number. In such case, it should be "1" based, and we need fix the other side instead.

stephenxs · 2020-02-17T13:56:36Z

What is the definition of the index here? I saw most of the implementation was "front pannel" port number. In such case, it should be "1" based, and we need fix the other side instead.

Hi @zhenggen-xu,
AFAIK it should be 0 based otherwise it will fail the xcvrd.
Could you please provide an example of a "1"-based port_config.ini? I'd like to check.
Thanks.

device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/port_config.ini

prsunny · 2020-02-19T02:33:43Z

Looks like this change is specific to fix a platform driver and would like Joe/Guohan to comment. Approving from my side!

nazariig · 2020-02-20T12:54:10Z

device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-C28D8/port_config.ini

@@ -1,37 +1,37 @@
 # name          lanes                  speed        alias       index


@stephenxs # name lanes alias index speed fec autoneg

@nazariig

Dismissing my approval until comment from @nazariig is resolved

zhenggen-xu · 2020-02-25T20:10:52Z

What is the definition of the index here? I saw most of the implementation was "front pannel" port number. In such case, it should be "1" based, and we need fix the other side instead.

Hi @zhenggen-xu,
AFAIK it should be 0 based otherwise it will fail the xcvrd.
Could you please provide an example of a "1"-based port_config.ini? I'd like to check.
Thanks.

https://github.com/Azure/sonic-buildimage/blob/master/device/celestica/x86_64-cel_seastone-r0/Celestica-DX010-C32/port_config.ini

My point is the xcvrd should handle both cases, it should probably use the port_config.ini as Source of Truth?

stephenxs · 2020-02-26T01:49:26Z

What is the definition of the index here? I saw most of the implementation was "front pannel" port number. In such case, it should be "1" based, and we need fix the other side instead.

Hi @zhenggen-xu,
AFAIK it should be 0 based otherwise it will fail the xcvrd.
Could you please provide an example of a "1"-based port_config.ini? I'd like to check.
Thanks.

https://github.com/Azure/sonic-buildimage/blob/master/device/celestica/x86_64-cel_seastone-r0/Celestica-DX010-C32/port_config.ini

My point is the xcvrd should handle both cases, it should probably use the port_config.ini as Source of Truth?

Hi zhenggen,
Thank you for pointing out.
Let's handle the issue on Mellanox-2700-D48C8 for now in this PR and consider a comprehensive solution in the future.

zhenggen-xu · 2020-02-26T18:31:04Z

What is the definition of the index here? I saw most of the implementation was "front pannel" port number. In such case, it should be "1" based, and we need fix the other side instead.

Hi @zhenggen-xu,
AFAIK it should be 0 based otherwise it will fail the xcvrd.
Could you please provide an example of a "1"-based port_config.ini? I'd like to check.
Thanks.

https://github.com/Azure/sonic-buildimage/blob/master/device/celestica/x86_64-cel_seastone-r0/Celestica-DX010-C32/port_config.ini
My point is the xcvrd should handle both cases, it should probably use the port_config.ini as Source of Truth?

Hi zhenggen,
Thank you for pointing out.
Let's handle the issue on Mellanox-2700-D48C8 for now in this PR and consider a comprehensive solution in the future.

If the indexes are presenting front pannel ports, to fix the error in xvrd, we need reload some of the plugins in your platform code in sonic_platform directory. The changes are fine if the 0 based port index is what you are looking for.

liat-grozovik · 2020-02-27T19:09:13Z

retest vsimage please

stephenxs · 2020-03-01T11:49:02Z

Retest vsimage please

stephenxs · 2020-03-03T04:55:12Z

retest vsimage please

liat-grozovik · 2020-03-03T19:44:14Z

retest vsimage please

stephenxs · 2020-03-04T12:48:19Z

retest vsimage please

stephenxs · 2020-03-09T08:57:56Z

Hi @jleveque, could you please cherry-pick it to 201911? Thanks.

…ic-net#4152)

qiluo-msft · 2020-04-30T21:27:31Z

Fixed sonic-net/sonic-utilities#588

lguohan · 2020-05-06T19:01:30Z

@zhenggen-xu is right. Check out the porting guide here.

https://github.com/Azure/SONiC/wiki/Porting-Guide

index: Physical index of port (optional - needed if ports do not begin with index zero or increment by one), When this column is missing the index starts from 0 and increase by 1 for each row. It is recommend to explicitly set this index column and make the index number match the labeling of the front panel ports. AKA: if the front panel ports are starting from 1, the index should start from 1. If the front panel ports start from 0, the index should start form 0. The break out ports from the same physical port should have same index.

…lly (#25637) #### Why I did it src/sonic-swss ``` * dbe0768 - (HEAD -> master, origin/master, origin/HEAD) Fix the "Invalid BUFFER QUEUE" error (#4224) (6 hours ago) [saksarav-nokia] * d29d7ea - This patch is to fix a major bug in the for loop of the function AclRange::remove. (#4256) (9 hours ago) [ashishalok-arista] * 35288a6 - Fix performance issue in fpmsyncd for non-ZMQ configuration (#4219) (9 hours ago) [venkit-nexthop] * 1c384fb - Merge pull request #4022 from ksravani-hcl/swss_1 (12 hours ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 36d98d6 - Enable response pipeline for P4Orch. (22 hours ago) [mint570] |/ * 6386066 - [build] Add docker-based build environment (#3715) (22 hours ago) [Lawrence Lee] * 26ec756 - [buffermgrd] Wait for lossless buffer profile to be applied to SAI (#4154) (23 hours ago) [ganglv] * 599eae7 - [tunnel] use warning message when setting a create-only attribute (#4212) (27 hours ago) [Yakiv Huryk] * ebf8c73 - [orchagent] Fix getopt string for -R option (ring_thread_enabled regression) (#4207) (27 hours ago) [Chiranjeevi U - MapleLabs] * aa08101 - Avoid using an uninitialized source MAC address (#4201) (28 hours ago) [Andriy Yurkiv] * 2a258c23 - Added mux neighbor_mode support with prefix-route (#4152) (31 hours ago) [manamand2020] * 9616cd5 - [ci] Install redis from Debian (#4241) (34 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog

…lly (sonic-net#25637) #### Why I did it src/sonic-swss ``` * dbe0768 - (HEAD -> master, origin/master, origin/HEAD) Fix the "Invalid BUFFER QUEUE" error (sonic-net#4224) (6 hours ago) [saksarav-nokia] * d29d7ea - This patch is to fix a major bug in the for loop of the function AclRange::remove. (sonic-net#4256) (9 hours ago) [ashishalok-arista] * 35288a6 - Fix performance issue in fpmsyncd for non-ZMQ configuration (sonic-net#4219) (9 hours ago) [venkit-nexthop] * 1c384fb - Merge pull request sonic-net#4022 from ksravani-hcl/swss_1 (12 hours ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 36d98d6 - Enable response pipeline for P4Orch. (22 hours ago) [mint570] |/ * 6386066 - [build] Add docker-based build environment (sonic-net#3715) (22 hours ago) [Lawrence Lee] * 26ec756 - [buffermgrd] Wait for lossless buffer profile to be applied to SAI (sonic-net#4154) (23 hours ago) [ganglv] * 599eae7 - [tunnel] use warning message when setting a create-only attribute (sonic-net#4212) (27 hours ago) [Yakiv Huryk] * ebf8c73 - [orchagent] Fix getopt string for -R option (ring_thread_enabled regression) (sonic-net#4207) (27 hours ago) [Chiranjeevi U - MapleLabs] * aa08101 - Avoid using an uninitialized source MAC address (sonic-net#4201) (28 hours ago) [Andriy Yurkiv] * 2a258c23 - Added mux neighbor_mode support with prefix-route (sonic-net#4152) (31 hours ago) [manamand2020] * 9616cd5 - [ci] Install redis from Debian (sonic-net#4241) (34 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <fenpan@microsoft.com>

…atically (#25254) #### Why I did it src/sonic-utilities ``` * 20a7131b - (HEAD -> master, origin/master, origin/HEAD) clear: make --namespace optional for arp and ndp commands (#4355) (5 minutes ago) [Oleksandr Ivantsiv] * f56e4a78 - show version: replace --verbose with --brief flag (#4350) (20 hours ago) [Ashwin Srinivasan] * 5e50cf3d - Wait for monit monitor <service> operation to complete during config (#4295) (23 hours ago) [Hemanth Kumar Tirupati] * 0306ea20 - Change sensorshow conn to use TCP socket (#4343) (2 days ago) [Chenyang Wang] * cb5b3e82 - Fix route_check.py redis client memory usage (#4217) (2 days ago) [Roee Bar] * e93a5c3c - config: allow golden config to override mac, platform, asic_id (#4348) (2 days ago) [securely1g] * 0024c8d4 - Add non -B- hwsku names as well (#4331) (2 days ago) [dakotac-arista] * eb7301cc - Fix unit tests (#4345) (3 days ago) [william8545] * 052199c0 - [Arista] Add Arista-7050CX3-32C-C28S4 to generic_config_updater (#4257) (4 days ago) [byu343] * ed68290a - Add multi-ASIC namespace support for show/config subinterface(s) command (#4298) (4 days ago) [william8545] * 9c9f099d - New CLI proposal for PHY diagnostics (#4214) (4 days ago) [Prince George] * 9e3373df - Fix generate_dump to preserve per-ASIC subdirectory structure for sdk_dbg collection (#4334) (4 days ago) [william8545] * 3fe8972f - Add multi-ASIC namespace support for ARP/NDP show and clear commands (#4231) (4 days ago) [Oleksandr Ivantsiv] * be5fe2aa - Add multi-ASIC namespace support for VLAN and FDB operations (#4230) (4 days ago) [Oleksandr Ivantsiv] * e74fca78 - Add multi-ASIC namespace support for static route commands (#4269) (4 days ago) [Oleksandr Ivantsiv] * 599e7c71 - Add multi-ASIC namespace support for ACL table add/remove commands (#4270) (4 days ago) [Oleksandr Ivantsiv] * d09d6cd6 - Add CLI support for "show interfaces <intf> <phy-signal/phy-serdes>" commands (#4312) (4 days ago) [prajjwal-arista] * 345f5686 - Add multi-asic namespace support for IPv6 link-local commands (#4289) (4 days ago) [william8545] * edd4b190 - Add multi-asic namespace support for crm show resources command (#4290) (4 days ago) [william8545] * 2b52a051 - [multi-asic] Add namespace support for vxlan and vnet show/config commands (#4299) (4 days ago) [william8545] * 03160905 - [fast-reboot][cosmetic] Fixed debug/error prints with the correct reboot type (#4285) (4 days ago) [Yair Raviv] * 6eedf8a7 - [warm-reboot][multi-asic] Added error-handling for faulty ASIC/s after orchagent freeze (#4297) (4 days ago) [Yair Raviv] * 2330bab5 - [BMC] Add new BMC CLIs for manual session management and reset root password (#4238) (4 days ago) [Ben Levi] * 4d0cc933 - Fix issue: pmon services's restart count is not cleared during config reload (#4314) (4 days ago) [Stephen Sun] * 0a1bbc55 - Fix the generate_dump for BCM Asic Q3D (#4326) (6 days ago) [saksarav-nokia] * 1580ccce - GCU generates suboptimal plan for CreateOnly paths (#4335) (6 days ago) [Brad House - Nexthop] * 369e703e - GCU: Add path tracing support (#4317) (7 days ago) [Brad House - Nexthop] * bc05e1a4 - [GCU]: Restart telemetry container on port speed change via GCU to handle OID update (#4248) (7 days ago) [Xincun Li] * 73f1ea51 - Fix warning messages due to nose test deprecation (#4322) (8 days ago) [Brad House - Nexthop] * ebfefbd8 - [Arista] Add TH5 HWSKU to list for pfcwd support (#4329) (8 days ago) [dakotac-arista] * 0d969b85 - [DPU] Add support for HA Set Counters (#4283) (8 days ago) [Connor Roos] * 44f8c37b - [DPU] Add CLI to trigger and dump flows (#4278) (8 days ago) [Vivek] * 76bf567e - [show interfaces] "show interfaces flap" command does not support multi-ASIC platforms (#4316) (9 days ago) [pnakka28] * 2ec21e19 - Limit PFC WD Detection time to maximum value of 1000ms (#4306) (9 days ago) [Hemanth Kumar Tirupati] * 99b1b76a - Modified dualtor_neighbor_check to use mux neighbor_mode (#4227) (10 days ago) [manamand2020] * 5dfd11ed - Fix 'show version' KeyError when sonic_version.yml has missing fields (#4324) (10 days ago) [securely1g] * 4c77f9d4 - fix: skip PORT_INGRESS/EGRESS_MIRROR_CAPABLE check for ERSPAN mirror sessions (#4323) (11 days ago) [bingwang-ms] * d8d2a39e - fix scapy delayed import when we have large routes (#4315) (11 days ago) [Hemanth Kumar Tirupati] * c6601cda - [LACP retry-count] Syntax Fix for Trixie (#4274) (11 days ago) [Yair Raviv] * f54d0a7c - Add fsync to config save to persist config across power cycle (#4313) (11 days ago) [Jianyue Wu] * e5f77f61 - Fix unit test assertions broken by spelling typo PRs (#4321) (13 days ago) [rustiqly] * 7660b19f - Fix spelling typos in muxcable modules (#4259) (2 weeks ago) [rustiqly] * f7d820f3 - Fix spelling typos in config/main.py (#4261) (2 weeks ago) [rustiqly] * 244942bd - Fix spelling typos in scripts/ (#4262) (2 weeks ago) [rustiqly] * 89001b10 - Fix spelling typos in show/ and clear/ modules (#4263) (2 weeks ago) [rustiqly] * d6e646c2 - Fix spelling typos in config/config_mgmt.py (#4260) (2 weeks ago) [rustiqly] * e244129c - Fix spelling typos in config/nat.py (#4258) (2 weeks ago) [rustiqly] * 5a0c48f0 - In route_check.py, Convey the IJSON Backend using an env variable (#4294) (2 weeks ago) [venkit-nexthop] * e2712fc1 - Fix spelling typos across utilities_common, config plugins, and misc modules (#4264) (2 weeks ago) [rustiqly] * 4211edee - Fixed show vxlan remotemac ambiguity (#4121) (2 weeks ago) [Gnanapriya [Marvell]] * cfd23f97 - Add FEC histograms to generate_dump output (#4244) (2 weeks ago) [Fraser Gordon] * 8882a633 - [storm-control] Fixed show storm-control interface command display (#4122) (2 weeks ago) [Gnanapriya [Marvell]] * 7a1e656e - [fibshow]: Fix exception when blackhole routes are present (#4189) (2 weeks ago) [Ravi Minnikanti(Marvell)] * 2b3f14de - [marvell-teralynx] Enhance techsupport to include HWSKU configs (#4161) (3 weeks ago) [Naveen-Rampuram] * 9cb7b3e6 - Merge pull request #4275 from tirupatihemanth/fix_scapy_lagkeepalive (3 weeks ago) [Ying Xie] |\ | failure_prs.log skip_prs.log 7e54ddff - Fix delayed scapy import when we have a lot of routes (3 weeks ago) [Hemanth Kumar Tirupati] * | cbb31f0d - [multi-asic] fix utilities_common Db helper (#4273) (3 weeks ago) [Yakiv Huryk] * | f65ddfa2 - Prevent early exit of reboot status (#4282) (3 weeks ago) [Gagan Punathil Ellath] * | 14840074 - [fast-reboot] Remove teamsyncd timer override by fast-boot (#4233) (3 weeks ago) [Yair Raviv] * | a3085380 - [lag_keepalive] add `--namespace` option (#4194) (4 weeks ago) [Yair Raviv] * | abc8bba1 - [teamd_retry_count] Add support for --namespace parameter (#4195) (4 weeks ago) [Yair Raviv] * | c05d995c - [warm/fast-reboot] check per-ASIC FW upgrade status (#4196) (4 weeks ago) [Yair Raviv] * | 433d01c1 - [check_db_integrity] Add NETNS environment (#4197) (4 weeks ago) [Yair Raviv] * | 441595c7 - [centralize_database] Add --namespace option (#4198) (4 weeks ago) [Yair Raviv] * | 0f3b5291 - [multi-asic][warm-reboot] Support warm-reboot on Multi-ASIC systems (#4199) (4 weeks ago) [Yair Raviv] * | 28623ca9 - [multi-asic][warm_restart] add Multi-ASIC support for warm_restart commands (#4200) (4 weeks ago) [Yair Raviv] * | 3cd228af - Add filesystem sync after plugin installation (#4251) (4 weeks ago) [Jianyue Wu] * | 1d78c210 - Add .github/copilot-instructions.md for AI-assisted development (#4271) (4 weeks ago) [rustiqly] * | 7895da57 - Fix dump port state CLI command crash on multi-asic platforms (#4229) (4 weeks ago) [Setu Patel] |/ * bcb1d4bb - Clearing /tmp/tmp* is unsafe with parallel builds (#4268) (4 weeks ago) [Brad House - NextHop] * 8103627e - Fix sonic-utilities submodule update failure due to ijson library (#4256) (4 weeks ago) [venkit-nexthop] * 85becedc - [Mellanox] Add restricted sysfs to fw control list (#4240) (4 weeks ago) [Noa Or] * 275bdc6c - Add multi-asic support for sonic-clear queue wredcounters and counter poll , --nonzero support for show queue wredcounters (#4152) (5 weeks ago) [saksarav-nokia] * fbc85ee4 - Fix j2 files not getting packaged (#4250) (5 weeks ago) [Saikrishna Arcot] * a9543cba - Fix route_check.py to not hog a lot of memory (#4205) (5 weeks ago) [venkit-nexthop] * 40260d5b - Fix JsonMove._get_value to Support Both String and Integer List Indices (#4237) (5 weeks ago) [Xincun Li] * 0a3ef184 - refactor: enhance show bfd summary command (#4242) (5 weeks ago) [Chenyang Wang] * 7c6dfdc2 - Update the error message for sfputil debug loopback command (#4224) (5 weeks ago) [Ariz Zubair] * f246da25 - [Fast-linkup] Added CLIs for config/show (#4182) (6 weeks ago) [Yair Raviv] * 87703c1 - Use Singleton PlatformDataProvider to reduce module import time (#4183) (6 weeks ago) [Hemanth Kumar Tirupati] * 0dae5f2 - [sfputil] Fix issue: should not do low power mode or reset for non-present ports (#4206) (6 weeks ago) [Junchao-Mellanox] * 5f56518 - generate_dump: add interface FEC stats (#4093) (6 weeks ago) [Fraser Gordon] * 2e9e81c - [GCU] Update WRED_PROFILE and BUFFER_POOL validators for GCU (#4219) (6 weeks ago) [Dev Ojha] * 2350203 - Update bash completions for sonic-utilities commands (#4163) (6 weeks ago) [Saikrishna Arcot] * 5052e02 - Fix the PSU show command error message on platform without psu at all (#4151) (6 weeks ago) [Yuanzhe] * 7d9ec5d - Fix issue that namespace is not correctly fetched in Multi ASIC environment for mirror capability checking (#4159) (6 weeks ago) [Stephen Sun] * f473b4f - Fix multi asic initialization for dump command (#4108) (6 weeks ago) [Gagan Punathil Ellath] * 0f45e43 - Add current and configured frequency to DOM CLI (#4209) (7 weeks ago) [Ariz Zubair] * 6f0b181 - Added counterpoll CLI support (#4106) (7 weeks ago) [Dhanasekar Rathinavel] * 3d5bef9 - [multi-asic][Mellanox] Add multi-ASIC support for generate_dump and update FW upgrade script (#4192) (7 weeks ago) [Oleksandr Ivantsiv] * 8451f01 - sonic-utilities: Support for clearing aggregate VOQ counters(#2001) (#4044) (8 weeks ago) [manish1-arista] * 21f013f - Add q3d SKUs to gcu_field_operation_validators.conf.json (#4201) (8 weeks ago) [HP] * 1a15091 - Fix multi asic connection creation (#4109) (8 weeks ago) [Gagan Punathil Ellath] ``` #### How I did it #### How to verify it #### Description for the changelog

…lly (#25637) #### Why I did it src/sonic-swss ``` * dbe0768e - (HEAD -> master, origin/master, origin/HEAD) Fix the "Invalid BUFFER QUEUE" error (#4224) (6 hours ago) [saksarav-nokia] * d29d7ea1 - This patch is to fix a major bug in the for loop of the function AclRange::remove. (#4256) (9 hours ago) [ashishalok-arista] * 35288a65 - Fix performance issue in fpmsyncd for non-ZMQ configuration (#4219) (9 hours ago) [venkit-nexthop] * 1c384fb6 - Merge pull request #4022 from ksravani-hcl/swss_1 (12 hours ago) [StephenWangGoogle] |\ | failure_prs.log skip_prs.log 36d98d61 - Enable response pipeline for P4Orch. (22 hours ago) [mint570] |/ * 63860664 - [build] Add docker-based build environment (#3715) (22 hours ago) [Lawrence Lee] * 26ec7561 - [buffermgrd] Wait for lossless buffer profile to be applied to SAI (#4154) (23 hours ago) [ganglv] * 599eae77 - [tunnel] use warning message when setting a create-only attribute (#4212) (27 hours ago) [Yakiv Huryk] * ebf8c73f - [orchagent] Fix getopt string for -R option (ring_thread_enabled regression) (#4207) (27 hours ago) [Chiranjeevi U - MapleLabs] * aa081017 - Avoid using an uninitialized source MAC address (#4201) (28 hours ago) [Andriy Yurkiv] * 2a258c2 - Added mux neighbor_mode support with prefix-route (#4152) (31 hours ago) [manamand2020] * 9616cd52 - [ci] Install redis from Debian (#4241) (34 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: dprital <drorp@nvidia.com>

Stephen Sun added 2 commits February 13, 2020 22:21

[port_config.ini]the port index should starts from 0

e33a7f6

[port_config.ini]Also amend the port_config.ini in Mellanox-2700-C28D8

274b6eb

stephenxs mentioned this pull request Feb 14, 2020

[Mellanox]the port index in port_config.ini should starts from 0 stephenxs/sonic-buildimage#27

Closed

prsunny reviewed Feb 14, 2020

View reviewed changes

device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/port_config.ini Outdated Show resolved Hide resolved

jleveque added Enhancement ➕ Platform: Mellanox labels Feb 14, 2020

Fix typo.

79274f7

liat-grozovik previously approved these changes Feb 16, 2020

View reviewed changes

prsunny reviewed Feb 19, 2020

View reviewed changes

device/mellanox/x86_64-mlnx_msn2700-r0/Mellanox-SN2700-D48C8/port_config.ini Outdated Show resolved Hide resolved

prsunny previously approved these changes Feb 19, 2020

View reviewed changes

nazariig requested changes Feb 20, 2020

View reviewed changes

jleveque previously approved these changes Feb 20, 2020

View reviewed changes

Address comments

8af77e5

stephenxs dismissed stale reviews from prsunny and liat-grozovik via 8af77e5 February 25, 2020 08:07

nazariig approved these changes Feb 25, 2020

View reviewed changes

prsunny approved these changes Feb 25, 2020

View reviewed changes

jleveque approved these changes Mar 5, 2020

View reviewed changes

jleveque merged commit f6ec95c into sonic-net:master Mar 5, 2020

stephenxs deleted the fix-2700-other-sku branch March 5, 2020 03:15

jleveque added the Request for 201911 Branch label Mar 9, 2020

rlhui added the Included in 201911 Branch label Mar 15, 2020

rlhui pushed a commit that referenced this pull request Mar 15, 2020

[Mellanox]the port index in port_config.ini should starts from 0 (#4152)

bcfc3d1

prsunny added the Request_for_bmtor label Mar 24, 2020

tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020

[Mellanox]the port index in port_config.ini should starts from 0 (son…

659fa85

…ic-net#4152)

keboliu mentioned this pull request Apr 30, 2020

shows N/A SFP type sonic-net/sonic-utilities#588

Open

qiluo-msft added the Request for 201811 Branch label May 6, 2020

qiluo-msft removed the Request for 201811 Branch label May 6, 2020

Conversation

stephenxs commented Feb 14, 2020

Uh oh!

Uh oh!

zhenggen-xu commented Feb 14, 2020

Uh oh!

stephenxs commented Feb 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

prsunny commented Feb 19, 2020

Uh oh!

nazariig Feb 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhenggen-xu commented Feb 25, 2020

Uh oh!

stephenxs commented Feb 26, 2020

Uh oh!

zhenggen-xu commented Feb 26, 2020

Uh oh!

liat-grozovik commented Feb 27, 2020

Uh oh!

stephenxs commented Mar 1, 2020

Uh oh!

stephenxs commented Mar 3, 2020

Uh oh!

liat-grozovik commented Mar 3, 2020

Uh oh!

stephenxs commented Mar 4, 2020

Uh oh!

stephenxs commented Mar 9, 2020

Uh oh!

qiluo-msft commented Apr 30, 2020

Uh oh!

lguohan commented May 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

stephenxs commented Feb 17, 2020 •

edited

Loading

nazariig Feb 20, 2020 •

edited

Loading