Skip to content

[action] [PR:21813] Update management interface related configuration in MGMT_PORT_TABLE STATE_DB#728

Merged
mssonicbld merged 1 commit intoAzure:202405from
mssonicbld:cherry/msft-202405/21813
Feb 28, 2025
Merged

[action] [PR:21813] Update management interface related configuration in MGMT_PORT_TABLE STATE_DB#728
mssonicbld merged 1 commit intoAzure:202405from
mssonicbld:cherry/msft-202405/21813

Conversation

@mssonicbld
Copy link
Collaborator

…in STATE_DB

Why I did it

Currently Management interface related data is present in CONFIG_DB and 'oper_status' is present in STATE_DB MGMT_PORT_TABLE.
This PR change is made to ensure that all telemetry data related to management interface is present in STATE_DB.

Work item tracking
  • Microsoft ADO 27597775:

How I did it

Update mgmt_oper_status monit script to update all fields from CONFIG_DB MGMT_PORT table.

How to verify it

Unit test added for the change and passed:

/sonic/files/image_config/monit$ pytest-3 tests/test_mgmt_oper_status.py
=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.11.2, pytest-7.2.1, pluggy-1.0.0+repack
rootdir: /sonic/files/image_config/monit
plugins: pyfakefs-5.6.0, cov-4.0.0
collected 4 items

tests/test_mgmt_oper_status.py ....                                                                                                                                                                         [100%]

================================================================================================ 4 passed in 0.09s ================================================================================================

Before Change:

sonic-db-cli STATE_DB hgetall "MGMT_PORT_TABLE|eth0"
{'oper_status': 'up'}

After change:

sonic-db-cli STATE_DB hgetall "MGMT_PORT_TABLE|eth0"
{'oper_status': 'up', 'admin_status': 'up', 'alias': 'eth0'}
sonic-db-cli CONFIG_DB hgetall "MGMT_PORT|eth0"
{'admin_status': 'up', 'alias': 'eth0'}

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

…STATE_DB

…in STATE_DB

<!--
     Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

     ** Make sure all your commits include a signature generated with `git commit -s` **

     If this is a bug fix, make sure your description includes "fixes #xxxx", or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it
Currently Management interface related data is present in CONFIG_DB and 'oper_status' is present in STATE_DB MGMT_PORT_TABLE.
This PR change is made to ensure that all telemetry data related to management interface is present in STATE_DB.

##### Work item tracking
- Microsoft ADO **27597775**:

#### How I did it
Update mgmt_oper_status monit script to update all fields from CONFIG_DB MGMT_PORT table.

#### How to verify it
Unit test added for the change and passed:
```
/sonic/files/image_config/monit$ pytest-3 tests/test_mgmt_oper_status.py
=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.11.2, pytest-7.2.1, pluggy-1.0.0+repack
rootdir: /sonic/files/image_config/monit
plugins: pyfakefs-5.6.0, cov-4.0.0
collected 4 items

tests/test_mgmt_oper_status.py ....                                                                                                                                                                         [100%]

================================================================================================ 4 passed in 0.09s ================================================================================================
```
Before Change:
```
sonic-db-cli STATE_DB hgetall "MGMT_PORT_TABLE|eth0"
{'oper_status': 'up'}
```
After change:
```
sonic-db-cli STATE_DB hgetall "MGMT_PORT_TABLE|eth0"
{'oper_status': 'up', 'admin_status': 'up', 'alias': 'eth0'}
sonic-db-cli CONFIG_DB hgetall "MGMT_PORT|eth0"
{'admin_status': 'up', 'alias': 'eth0'}
```

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
@mssonicbld
Copy link
Collaborator Author

Original PR: sonic-net/sonic-buildimage#21813

@mssonicbld
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit fd6d85e into Azure:202405 Feb 28, 2025
16 checks passed
liushilongbuaa pushed a commit that referenced this pull request Mar 25, 2026
…D automatically (#25994)

#### Why I did it
src/sonic-platform-daemons
```
* b85fff3 - (HEAD -> master, origin/master, origin/HEAD) Set DOM polling interval based on the time at the start of the loop instead of the end. (#757) (7 hours ago) [Aditya Bhiday]
* 7d8007d - [Smartswitch] Use MODULE_ADMIN_DOWN when DPU operational state is offline (#772) (35 hours ago) [Gagan Punathil Ellath]
* 4c23a4e - Support parsing gearbox configuration from media_settings.json (#728) (4 days ago) [Brian Gallagher]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant