Skip to content

[bgp]: Add sudo check for TSA/B/C command execution (#15288)#62

Merged
gechiang merged 1 commit intoAzure:202205from
gechiang:ghc-202205
Jul 13, 2023
Merged

[bgp]: Add sudo check for TSA/B/C command execution (#15288)#62
gechiang merged 1 commit intoAzure:202205from
gechiang:ghc-202205

Conversation

@gechiang
Copy link
Contributor

TSA/B/C scripts invoke commands that require root permissions. If the user does not have sudo permissions, the scripts today execute until the command and throw a backtrace with error at the specific command. Added a check to ensure the operations check for root permissions upfront.

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

TSA/B/C scripts invoke commands that require root permissions. If the user does not have sudo permissions, the scripts today execute until the command and throw a backtrace with error at the specific command. Added a check to ensure the operations check for root permissions upfront.
@gechiang gechiang requested a review from lguohan as a code owner July 13, 2023 23:03
@gechiang gechiang merged commit 0c4ed8f into Azure:202205 Jul 13, 2023
jon-nokia pushed a commit to jon-nokia/sonic-buildimage-msft that referenced this pull request Aug 9, 2023
24f505148 [eloop.c]: Increase timeout of signal termination (Azure#62)
2b2c1ad72 [driver_macsec_sonic.c]: Fixbug: a wrong db_wait in delete sa (Azure#61)

Signed-off-by: Ze Gan <ganze718@gmail.com>
jon-nokia pushed a commit to jon-nokia/sonic-buildimage-msft that referenced this pull request Aug 9, 2023
24f505148 [eloop.c]: Increase timeout of signal termination (Azure#62)
2b2c1ad72 [driver_macsec_sonic.c]: Fixbug: a wrong db_wait in delete sa (Azure#61)

Signed-off-by: Ze Gan <ganze718@gmail.com>
mssonicbld added a commit that referenced this pull request Mar 12, 2025
… automatically (#852)

#### Why I did it
src/sonic-platform-common
```
* c20c319 - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-platform-common:202411 to 202412 (#62) (21 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Mar 17, 2025
…lly (#907)

#### Why I did it
src/sonic-swss
```
* 6639e3a - (HEAD -> 202412, origin/202412) [code sync] Merge code from sonic-net/sonic-swss:202411 to 202412 (#62) (22 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
r12f pushed a commit that referenced this pull request Jun 30, 2025
…D automatically (#1283)

#### Why I did it
src/sonic-sairedis
```
* 0ae8494 - (HEAD -> 202412, origin/HEAD, origin/202412) [unittest ]Conditionally enable TestServerSaiMockChannel (#67) (37 minutes ago) [mssonicbld]
* 12b21f3 - [syncd] Check whether stat_st and tam_telemetry is defined (#1590) (#65) (5 days ago) [Ze Gan]
* 701a114 - [TAM]: Fix TAM notification and vslib implementation (#1606) (#62) (5 days ago) [Ze Gan]
* 6b97f74 - [SAI]: Update SAI to support QUERY_STATS_ST_CAPABILITY and TAM (#1573) (#63) (5 days ago) [Ze Gan]
```
#### How I did it
#### How to verify it
#### Description for the changelog
prabhataravind pushed a commit that referenced this pull request Jul 7, 2025
…ly (#21230)

#### Why I did it
src/dhcprelay
```
* b242307 - (HEAD -> master, origin/master, origin/HEAD) Revert "Fail build when test fail (#53)" (#62) (19 hours ago) [Yaqiang Zhu]
* dbaee8b - Fail build when test fail (#53) (6 days ago) [Yaqiang Zhu]
* ef7b972 - [Build] Update to build bookworm debian package (#55) (8 days ago) [Yaqiang Zhu]
* 011066a - Add wait and check ip address check when dhcp6relay init (#52) (11 days ago) [Yaqiang Zhu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
prabhataravind pushed a commit that referenced this pull request Jul 7, 2025
…ly (#22416)

#### Why I did it
src/sonic-stp
```
* a80676a - (HEAD -> master, origin/master, origin/HEAD) MSTP utility APIs (#62) (2 days ago) [Divya Kumaran Chandralekha]
* 2c3eccc - MSTP extern API declaration (#63) (2 days ago) [Divya Kumaran Chandralekha]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Jul 8, 2025
…D automatically (#1323)

#### Why I did it
src/sonic-sairedis
```
* c4d152d4 - (HEAD -> 202503, origin/202503) Merge pull request #59 from mssonicbld/sonicbld/202503-merge (23 hours ago) [mssonicbld]
* 8f50be71 - Merge branch '202412' of https://github.com/Azure/sonic-sairedis.msft into 202503 (23 hours ago) [Sonic Automation]
* b36d5641 - (origin/HEAD, origin/202412, 202412) [trim]: Add Packet Trimming Asym DSCP to VS lib (#68) (4 days ago) [mssonicbld]
* 6e75cc6c - [TAM]: Add default SAI_TAM_ATTR_TELEMETRY_OBJECTS_LIST of TAM for saivs create operation (#1614) (#66) (8 days ago) [Ze Gan]
* 0ae8494d - [unittest ]Conditionally enable TestServerSaiMockChannel (#67) (8 days ago) [mssonicbld]
* 12b21f3b - [syncd] Check whether stat_st and tam_telemetry is defined (#1590) (#65) (13 days ago) [Ze Gan]
* 701a114b - [TAM]: Fix TAM notification and vslib implementation (#1606) (#62) (13 days ago) [Ze Gan]
* 6b97f74e - [SAI]: Update SAI to support QUERY_STATS_ST_CAPABILITY and TAM (#1573) (#63) (13 days ago) [Ze Gan]
* f21e12ce - [trim]: Add Packet Trimming Port/Queue stats to VS lib (#60) (4 weeks ago) [Nazarii Hnydyn]
* 9d396448 - Merge pull request #61 from mssonicbld/cherry/msft-202412/1548 (4 weeks ago) [Ze Gan]
|\ 
| failure_prs.log 613654bb - [syncd] Move log set function after api initialize (4 weeks ago) [Sonic Build Admin]
|/ 
* e18530c8 - Update SAI version to 1.16.1 (#54) (8 weeks ago) [mramezani95]
* 3c33c26e - Update codeql runs-on ubuntu version to 22.04 (#56) (8 weeks ago) [mssonicbld]
* 87d6f464 - [trim]: Add Packet Trimming to VS lib (#55) (9 weeks ago) [mssonicbld]
* 80c43090 - Support auto negotiation on the VS platform to avoid error messages. (#52) (10 weeks ago) [mssonicbld]
* 0209ab89 - [FlexCounter] add support for SRv6 MySID counters (#50) (2 months ago) [mssonicbld]
* aceb9ed1 - Move time stamp to time stamp table in counter database to avoid frequently update the counter table (#51) (2 months ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Pterosaur pushed a commit that referenced this pull request Sep 12, 2025
…HEAD automatically (#1599)

#### Why I did it
src/sonic-swss-common
```
* 66ac80e - (HEAD -> 202412, origin/HEAD, origin/202412) Add c-api/Rust wrappers for ConfigDBConnector and EventPublisher (#66) (13 hours ago) [mssonicbld]
* 9e5b094 - Add test case to verify zmq reconnect behaviour (#63) (17 hours ago) [mssonicbld]
* b4a3cc6 - Ignore nonexistent include in database_global.json (#64) (17 hours ago) [mssonicbld]
* 4f576db - Move SonicDbTable to sonic-dash-ha. (#65) (17 hours ago) [mssonicbld]
* fd28e9d - Move swss-common/swss-common-testing crates from https://github.com/sonic-net/sonic-dash-ha (#62) (17 hours ago) [mssonicbld]
* 726586c - SWSSDBConnector_new_keyed to c-api (#61) (19 hours ago) [mssonicbld]
* 16a2234 - c-api: README.md (#60) (19 hours ago) [mssonicbld]
* b501364 - Add swss::Logger to c-api (#59) (23 hours ago) [mssonicbld]
* c51425c - C API Exceptions (#58) (24 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
bingwang-ms pushed a commit that referenced this pull request Jan 16, 2026
…ically (#22863)

#### Why I did it
src/sonic-dash-ha
```
* 000fa6b - (HEAD -> master, origin/master, origin/HEAD) swbus-edge support of reconnecting to swbusd (#62) (10 hours ago) [yue-fred-gao]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants