Skip to content

Changes to increase poll interval 10sec for port counter on supervisor.#507

Merged
abdosi merged 1 commit intoAzure:202405from
abdosi:counter
Jan 9, 2025
Merged

Changes to increase poll interval 10sec for port counter on supervisor.#507
abdosi merged 1 commit intoAzure:202405from
abdosi:counter

Conversation

@abdosi
Copy link
Contributor

@abdosi abdosi commented Jan 9, 2025

What I did:

Changes to increase poll interval 10sec for port counter on supervisor.
Reducing poll interval decreases cpu load as on packet chassis we can
have 600+ ethernet backplane ports.

For voq chaassis it is no-op as their is no ethernet port

How I verify:
Manual Verification of syncd cpu usage goes down.
Counter working fine.

Reducing poll interval decreases cpu load as on packet chassis we can
have 600+ ethernet backplane ports.

For voq chaassis it is no-op as their is no ethernet port

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi abdosi requested a review from lguohan as a code owner January 9, 2025 06:19
@abdosi abdosi requested a review from arlakshm January 9, 2025 06:19
@abdosi
Copy link
Contributor Author

abdosi commented Jan 9, 2025

@yejianquan / @rlhui for viz.

@abdosi
Copy link
Contributor Author

abdosi commented Jan 9, 2025

For master will raise separate PR as code flow is different where FLEX_COUNTER_TABLE in init_cfg.json is getting populated from init_cfg.json . enable_counters.py do not update config db any more.

@abdosi
Copy link
Contributor Author

abdosi commented Jan 9, 2025

@anamehra for viz.

Copy link
Contributor

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdosi abdosi merged commit c5fba9c into Azure:202405 Jan 9, 2025
@abdosi abdosi deleted the counter branch January 9, 2025 16:23
@arlakshm
Copy link
Contributor

arlakshm commented Jan 9, 2025

Hi @abdosi, can you do this only for the packet-chassis. In Voq chassis the fabric ports stats are also added the port_stat flex counter
https://github.com/sonic-net/sonic-swss/blob/381c0141b33d85af0ba4be787f57d7104ccf194e/orchagent/fabricportsorch.cpp#L76

liushilongbuaa pushed a commit that referenced this pull request Mar 25, 2026
…lly (#24623)

#### Why I did it
src/sonic-gnmi
```
* 5a62935 - (HEAD -> master, origin/master, origin/HEAD) gNOI: Add gNMI Server changes for Healthz Acknowledge RPC (#509) (25 hours ago) [jayaragini-hcl]
* ca045ea - Add support for ACL counter (#540) (2 days ago) [Feng-msft]
* 4a5afd4 - gNOI: Add support for Healthz List and Check RPC (#487) (2 days ago) [jayaragini-hcl]
* 08f7266 - gNOI: Add gNMI Server changes for Healthz Get RPC (#507) (2 days ago) [jayaragini-hcl]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants