Skip to content

[Nokia][sonic-platform] Update Nokia sonic-platform submodule for explicit sync to SSD when watchdog is known to be approaching#423

Merged
gechiang merged 2 commits intoAzure:202205from
snider-nokia:202205
Jul 31, 2024
Merged

[Nokia][sonic-platform] Update Nokia sonic-platform submodule for explicit sync to SSD when watchdog is known to be approaching#423
gechiang merged 2 commits intoAzure:202205from
snider-nokia:202205

Conversation

@snider-nokia
Copy link
Contributor

Why I did it

To ensure that write cache is flushed to SSD when SW has determined that a watchdog reset is approaching.

Work item tracking
  • Microsoft ADO (number only):

How I did it

When watchdog kicker script has determined that watchdog should no longer be kicked, due to degraded system health, explicitly and periodically issue sync commands until watchdog reset occurs.

How to verify it

This is difficult to verify without ad-hoc system modifications to simulate degraded system health. This functionality has been tested here in our labs and works.

Which release branch to backport (provide reason below if selected)

This logic will be added/ported separately for master/202405 branch(es).

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

  • 202205

Description for the changelog

[Nokia][sonic-platform] Update Nokia sonic-platform submodule for explicit sync to SSD when watchdog is known to be approaching

Link to config_db schema for YANG module changes

@snider-nokia snider-nokia requested a review from lguohan as a code owner July 25, 2024 14:15
@snider-nokia
Copy link
Contributor Author

@judyjoseph @deepak-singhal0408 @vmittal-msft @arlakshm, Please merge and use this change for next pilot candidate image build (along with NDK 22.9.30). NDK 22.9.30 and these changes do NOT NEED to be paired, however both these changes and NDK 22.9.30 are recommended for incorporation into next pilot candidate image build.

@judyjoseph
Copy link
Contributor

@snider-nokia @jon-nokia could you rebase this PR and the corresponding NDK PR

@jon-nokia
Copy link
Contributor

@snider-nokia @jon-nokia could you rebase this PR and the corresponding NDK PR

#426 has been rebased.

…licit sync to SSD when watchdog is known to be approaching
@snider-nokia
Copy link
Contributor Author

This one is rebased now too.

@judyjoseph
Copy link
Contributor

@snider-nokia Was going through the watchdog.sh, here below code line 145, is it intentional we echo this line into log file only if $watchdog_fail == 1, as we reset to 0 the first time we enter this if condition.

    if [[ $watchdog_fail -eq 1 ]]; then
        echo "enable watchdog kick" `date -u` >> $wd_init_log_file
        watchdog_fail=0
    fi

@snider-nokia
Copy link
Contributor Author

@snider-nokia Was going through the watchdog.sh, here below code line 145, is it intentional we echo this line into log file only if $watchdog_fail == 1, as we reset to 0 the first time we enter this if condition.

    if [[ $watchdog_fail -eq 1 ]]; then
        echo "enable watchdog kick" `date -u` >> $wd_init_log_file
        watchdog_fail=0
    fi

Yes Judy, it is intentional. This code handles the situation where $watchdog_fail was previously set to 1 because our health-check-ping-to-NDK did not succeed. When that occurs, and if a subsequent health-check-ping-to-NDK then does succeed then this logic tells us that such a scenario occurred and also reenables kicking of the watchdog. So, this logic is only handling/logging the case where we transitioned from unsuccessful health-check-ping-to-NDK back to successful health-check-ping-to-NDK.

@gechiang gechiang merged commit 74550d2 into Azure:202205 Jul 31, 2024
liushilongbuaa pushed a commit that referenced this pull request Dec 26, 2024
…tomatically (#20218)

#### Why I did it
src/sonic-linux-kernel
```
* 54ccf27 - (HEAD -> 202405, origin/202405) [202405] Update to Linux 6.1.94 (#423) (6 days ago) [Saikrishna Arcot]
```
#### How I did it
#### How to verify it
#### Description for the changelog
bingwang-ms pushed a commit that referenced this pull request Jan 16, 2026
…lly (#23750)

#### Why I did it
src/sonic-gnmi
```
* 8d1b029 - (HEAD -> master, origin/master, origin/HEAD) Add v2r mapping for Switch Packet Integrity Drop counter (#423) (10 hours ago) [Vineet Mittal]
* 4267aab - Downgrade Go to 1.19 for SONiC Bookworm FIPS compliance (#495) (5 days ago) [Dawei Huang]
* 56d0703 - Add dom and port options for SHOW client (#493) (8 days ago) [Yutong Zhang]
* 6c7432c - change the output fornat of show interface errors and show interface fec status to be list of dicts (#494) (8 days ago) [Changrong Wu]
* ee84ea0 - Fix ZMQ lost data when connection reset issue (#492) (9 days ago) [Hua Liu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants