Skip to content

[action] [PR:23510] KDUMP YANG: Update the regex to accept memory start range accept without suffix #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mssonicbld wants to merge 2 commits into from
Closed

[action] [PR:23510] KDUMP YANG: Update the regex to accept memory start range accept without suffix #1434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed6076c
KDUMP YANG: Update the regex to accept memory start range accept with…
mssonicbld Jul 31, 2025
0323b1b
Merge branch '202405' into cherry/msft-202405/23510
deepak-singhal0408 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sonic-yang-models/tests/yang_model_tests/tests/kdump.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"KDUMP_WITH_VALID_VALUES_3": {
"desc": "Configuring the kdump with valid values."
},
"KDUMP_WITH_VALID_VALUES_4": {
"desc": "Configuring the kdump with valid values."
},
"KDUMP_WITH_INVALID_NUM_DUMPS": {
"desc": "Configuring kdump config with a invalid number of allowed kdumps.",
"eStr": ["pattern", "does not satisfy"]
Expand Down
15 changes: 15 additions & 0 deletions src/sonic-yang-models/tests/yang_model_tests/tests_config/kdump.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,21 @@
}
}
},
"KDUMP_WITH_VALID_VALUES_4": {
"sonic-kdump:sonic-kdump": {
"sonic-kdump:KDUMP": {
"config": {
"enabled": "true",
"num_dumps": "3",
"memory": "512-4G:37M,4G-8G:41M,8G-:59M",
"remote": "true",
"ssh_string" : "ali@192.168.0.188",
"ssh_path": "/home/ali/.ssh/id_rsa"
}
}
}
},

"KDUMP_WITH_INVALID_NUM_DUMPS": {
"sonic-kdump:sonic-kdump": {
"sonic-kdump:KDUMP": {
Expand Down
2 changes: 1 addition & 1 deletion src/sonic-yang-models/yang-models/sonic-kdump.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ module sonic-kdump {

leaf memory {
type string {
pattern "(((([0-9]+[MG])?(-([0-9]+[MG])?):)?[0-9]+[MG],?)+)";
pattern "(((([0-9]+[MG]?)?(-([0-9]+[MG])?):)?[0-9]+[MG],?)+)";
}
description
"Memory reserved for loading the crash handler kernel. The amount
Expand Down
Loading