Skip to content

Enable macsec and delayed pmon start on disaggregated chassis#1118

Merged
arlakshm merged 1 commit intoAzure:202503from
tjchadaga:enable_macsec_on_upperspine
May 16, 2025
Merged

Enable macsec and delayed pmon start on disaggregated chassis#1118
arlakshm merged 1 commit intoAzure:202503from
tjchadaga:enable_macsec_on_upperspine

Conversation

@tjchadaga
Copy link
Contributor

Why I did it

  1. To start macsec on disaggregated chassis using UpperSpineRouter role
  2. Enable delayed pmon for all SpineRouter devices
Work item tracking
  • Microsoft ADO (number only):

How I did it

Change the check to enable macsec/delayed pmon

How to verify it

Check that macsec dockers are up on macsec-supported devices

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@tjchadaga tjchadaga requested a review from lguohan as a code owner May 13, 2025 23:21
@tjchadaga tjchadaga requested review from arlakshm and bingwang-ms May 13, 2025 23:31
@bingwang-ms
Copy link
Contributor

Can you help me understand why pmon should be delay started?

@arlakshm
Copy link
Contributor

Can you help me understand why pmon should be delay started?

@bingwang-ms, we disabled pmon delayed start on Chassis spinerouters because it causes delay in the bringup of the links esp. Fabric links This PR is extending the to Disagg SpineRouters as well.

@arlakshm arlakshm merged commit f50d56d into Azure:202503 May 16, 2025
3 of 4 checks passed
liushilongbuaa pushed a commit that referenced this pull request Mar 25, 2026
…omatically (#24285)

Why I did it
src/sonic-swss-common

* 7f1b50f - (HEAD -> master, origin/master, origin/HEAD) Revert "[sonic-db-cli] Add flag to make cli calls to container databases (#1070)" and #1111 (#1123) (5 hours ago) [Qi Luo]
* 16a8a93 - [ci] Use 1ES agent pool to provide more disk when building swss. (#1121) (2 days ago) [Liu Shilong]
* 7682785 - Revert "Fix risky unwrap(), expect(), and casting (#1113)" (#1118) (2 days ago) [Liu Shilong]
* cf7c7f6 - Fix issue where namespace would not be read (#1111) (2 days ago) [Connor Roos]
* d6ccff7 - Fix risky unwrap(), expect(), and casting (#1113) (4 days ago) [Qi Luo]
* e67092c - Add PORT_SERDES_ATTR_ID_LIST to FLEX COUNTER DATABASE (#1099) (9 days ago) [Dhanasekar Rathinavel]
* d2c8f2c - [ci] Migrate agent pool from sonicbld-1es to sonicso1ES-amd64 (#1101) (2 weeks ago) [Liu Shilong]
* 4b86a77 - [dhcp_relay] sonic dhcp relay agent for IPv4 (#1017) (4 weeks ago) [Akshath TR]
* 472a425 - SHlorch changes for EVPN MH feature (#1051) (5 weeks ago) [jayakj]
* 7407a2e - Optimize memory usage by replacing the queue's underlying container with a list. (#1083) (7 weeks ago) [Hua Liu]
* 130d8b6 - Add chassis db. (#1085) (7 weeks ago) [dypet]
* 66e437a - Fix mocktests for buster builds (#1087) (8 weeks ago) [prabhataravind]
* 32b14a4 - Update static database_config.json in swsscommon (#1086) (8 weeks ago) [prabhataravind]
* c253917 - Add pop batch size support for ZMQ Consumer (#1084) (8 weeks ago) [Vivek]
* 4fea06e - [sonic-db-cli] Add flag to make cli calls to container databases (#1070) (8 weeks ago) [Connor Roos]
liushilongbuaa pushed a commit that referenced this pull request Mar 25, 2026
…omatically (#24792)

#### Why I did it
src/sonic-swss-common
```
* 03c6777 - (HEAD -> master, origin/master, origin/HEAD) Opportunistically use a matching kernel version for building the modules (#1138) (2 days ago) [Saikrishna Arcot]
* 41acbf8 - Ensure RedisPipeline dtor not to throw (#1115) (5 days ago) [Qi Luo]
* e8a9592 - Reapply "Fix risky unwrap(), expect(), and casting (#1113)" (#1118) (#1124) (5 days ago) [Qi Luo]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants