Skip to content

Conversation

@hyoshioka0128
Copy link
Contributor

@hyoshioka0128 hyoshioka0128 commented Jul 9, 2025

Purpose

Description

Related Issue

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

  • Yes
  • No

Type of change

  • Bugfix
  • Feature
  • Code style update (e.g., formatting, local variables)
  • Refactoring (no functional or API changes)
  • Documentation content changes
  • Other... Please describe:

Checklist

Before submitting your pull request, please confirm the following:

  • I have thoroughly tested my changes: I confirm that I have run the code and manually tested all affected areas.
  • All existing tests pass: I have run all tests and confirmed that nothing is broken.
  • I have added new tests (if applicable): I have written tests that cover the new functionality introduced by my code changes.
  • I have followed the Co-op Translators coding conventions: My code adheres to the style guide and coding conventions outlined in the repository.
  • I have documented my changes (if applicable): I have updated the documentation to reflect the changes where necessary.

Additional context

image

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 9, 2025
Copy link
Collaborator

@skytin1004 skytin1004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hyoshioka0128, thanks for catching that!

This looks good. Would you be open to making the same fix in the original English version as well? Here's the link to the file:
https://github.com/Azure/co-op-translator/blob/main/getting_started/command-line-guide/install-package.md

@skytin1004 skytin1004 merged commit f8eb6bd into Azure:main Jul 10, 2025
2 checks passed
@skytin1004
Copy link
Collaborator

Hi @hyoshioka0128, thanks for catching that!

I just checked and noticed you've already applied the fix to both the original English and Japanese versions really appreciate the attention to detail!

Looks good to me. Thanks again for the contribution 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants