fix: Expose DataAsset class publicly #34814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdestin
requested review from
MilesHolland,
YusakuNo1,
diondrapeck,
luigiw,
needuv,
ninghu,
paulshealy1 and
singankit
as code owners
annatisch
reviewed
Mar 18, 2024
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_deployment/data_asset.py
Outdated
Show resolved
Hide resolved
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
luigiw
approved these changes
Mar 18, 2024
annatisch
approved these changes
Mar 19, 2024
kdestin
added a commit
to kdestin/azure-sdk-for-python
that referenced
this pull request
Mar 19, 2024
* fix: Expose DataAsset class publicly * doc: Fix DataAsset docstring * refactor: Make DataAsset params keyword only * refactor: Remove kwargs from model * refactor: Remove unused pylint directive * docs: Update typing in docstring
kdestin
added a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses ApiView review feedback that pointed out that an experimental model was not exposed publicly.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines