fix: prebuild client plugin in regen script #53673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Client
jorgerangel-msft
requested review from
ArcturusZhang,
christothes,
jsquire,
live1206 and
m-nash
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the parallel SDK regeneration process by pre-building the client plugin to avoid concurrent build operations. The change addresses potential race conditions and improves performance when regenerating multiple SDKs in parallel.
Key Changes:
- Added pre-build step for the client plugin before parallel regeneration
- Introduced
SkipBuildPlugin=trueparameter to skip redundant plugin builds during individual SDK regeneration - Refactored code to use a shared
$sdkForNetEngFoldervariable for consistency
Co-authored-by: Copilot <[email protected]>
JoshLove-msft
approved these changes
Nov 4, 2025
nick863
pushed a commit
that referenced
this pull request
Nov 5, 2025
* fix: prebuild client plugin in regen script * Update eng/packages/http-client-csharp/eng/scripts/RegenPreview.ps1 Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prebuilds the client plugin to avoid concurrency issues in the regen preview script.