Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 3, 2025

Add CONTRIBUTING doc for the Azure Generator

  • Create CONTRIBUTING.md file at /eng/packages/http-client-csharp/CONTRIBUTING.md
  • Adapt content from unbranded generator template
  • Update prerequisites (Node.js 20, .NET 9.0 SDK based on global.json)
  • Update repository URLs and references for azure-sdk-for-net
  • Remove "Validating Changes Against the Azure Generator" section
  • Simplify "Regenerating Azure Libraries" section to use RegenPreview.ps1
  • Update all script paths to match Azure Generator structure
  • Review and validate the final document
  • Address review feedback: simplify build command and remove Discussions link
  • Clarify that Spector filter works on directories and document coverage output location
  • Update filter example to use positional parameter syntax
Original prompt

This section details on the original issue you should resolve

<issue_title>Add CONTRIBUTING doc for the Azure Generator</issue_title>
<issue_description>A contributing guide should be added to https://github.com/Azure/azure-sdk-for-net/tree/main/eng/packages/http-client-csharp. It should follow the template of the unbranded generator's contributing guide. The https://github.com/microsoft/typespec/blob/main/packages/http-client-csharp/CONTRIBUTING.md#validating-changes-against-the-azure-generator section can be excluded. The https://github.com/microsoft/typespec/blob/main/packages/http-client-csharp/CONTRIBUTING.md#regenerating-azure-libraries can be included but should just have the RegenPreview command to run ./eng/scripts/RegenPreview.ps1.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add CONTRIBUTING guide for Azure Generator Add CONTRIBUTING.md for Azure Generator Nov 3, 2025
Copilot finished work on behalf of jorgerangel-msft November 3, 2025 22:00
Copilot finished work on behalf of jorgerangel-msft November 3, 2025 22:18
@jorgerangel-msft jorgerangel-msft marked this pull request as ready for review November 3, 2025 22:18
Copilot AI review requested due to automatic review settings November 3, 2025 22:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a comprehensive CONTRIBUTING.md guide for the Azure Generator, adapted from the unbranded generator template. The guide provides setup instructions, development workflows, testing procedures, and contribution guidelines specifically tailored for the Azure SDK environment.

Key Changes:

  • Created CONTRIBUTING.md with prerequisites updated for Node.js 20 and .NET 9.0 SDK
  • Included simplified "Regenerating Azure Libraries" section using RegenPreview.ps1
  • Updated all repository URLs and script paths to match azure-sdk-for-net structure

Copilot finished work on behalf of jorgerangel-msft November 3, 2025 22:33
@jorgerangel-msft jorgerangel-msft enabled auto-merge (squash) November 3, 2025 22:52
@jorgerangel-msft
Copy link
Member

/checkenforcer override

@jorgerangel-msft
Copy link
Member

/check-enforcer reset

@jorgerangel-msft
Copy link
Member

/check-enforcer evaluate

@jorgerangel-msft jorgerangel-msft merged commit 07edf50 into main Nov 3, 2025
8 checks passed
@jorgerangel-msft jorgerangel-msft deleted the copilot/add-contributing-doc-azure-generator branch November 3, 2025 23:31
nick863 pushed a commit that referenced this pull request Nov 5, 2025
* Initial plan

* Add CONTRIBUTING.md for Azure Generator

Co-authored-by: jorgerangel-msft <[email protected]>

* Address review feedback: remove cd command and Discussions link

Co-authored-by: jorgerangel-msft <[email protected]>

* Clarify Spector filter usage and coverage output location

Co-authored-by: jorgerangel-msft <[email protected]>

* Update Spector filter example to use http/type/array

Co-authored-by: jorgerangel-msft <[email protected]>

* Use positional parameter for Test-Spector.ps1 filter

Co-authored-by: jorgerangel-msft <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: jorgerangel-msft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CONTRIBUTING doc for the Azure Generator

3 participants