update provisioning test cases #53355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR updates provisioning test cases by consolidating helper methods and refactoring test patterns for better consistency and maintainability.
- Consolidates string helper methods into a unified
TestHelpersclass with additional assertion methods - Removes the standalone
StringHelpersclass and migrates functionality toTestHelpers - Updates existing tests to use the new helper methods and modernizes test patterns with async/await and fluent APIs
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TestHelpers.cs | New consolidated helper class with line ending normalization and Bicep expression assertion methods |
| StringHelpers.cs | Removed standalone string helper class |
| ProvisionableResourceTests.cs | Added new test case for validating list properties when unset |
| BicepValueTests.cs | Refactored to use new TestHelpers and modernized test pattern with async/await |
sdk/provisioning/Azure.Provisioning/tests/Primitives/ProvisionableResourceTests.cs
Outdated
Show resolved
Hide resolved
…ableResourceTests.cs Co-authored-by: Copilot <[email protected]>
ArthurMa1978
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.