[Search] Apply Search GA feedback in preview #53160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ports Azure Search GA feedback into the main branch while maintaining existing preview features. The changes align the codebase with the stable 2025-09-01 service version that was shipped in the GA release.
- Added
2025-09-01as a stable service version - Updated model factory methods and API surface to support GA requirements
- Made
NormalizerNameproperty settable inAnalyzeTextOptionsfor better usability
Reviewed Changes
Copilot reviewed 14 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SearchIndexClientTests.cs | Updated test to use object initializer for AnalyzeTextOptions instead of constructor |
| DataSourceTests.cs | Corrected constructor call to use named parameter for better clarity |
| autorest.md | Added directive to retain vector search compression properties for backward compatibility |
| SearchClientOptions.cs | Added V2025_09_01 service version and updated version mapping |
| SuggestResults.cs | Added suppression attribute for missing model factory analyzer warning |
| SearchResults.cs | Added suppression attribute and changed constructor access modifier |
| SearchModelFactory.cs | Added multiple new factory methods for better testing support |
| SearchResourceEncryptionKey.cs | Added new constructor overload accepting string parameters |
| SearchIndexerDataSourceConnection.cs | Added internal constructor overload for factory method support |
| AnalyzeTextOptions.cs | Made NormalizerName property settable and removed constructor overload |
| Azure.Search.Documents.csproj | Updated version numbers and removed obsolete package reference and warning suppression |
| API files | Updated public API surface to reflect all changes |
| CHANGELOG.md | Added release notes for GA version with breaking changes documentation |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
jsquire
approved these changes
Oct 11, 2025
alzimmermsft
approved these changes
Oct 13, 2025
Member
|
/check-enforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shipped Search GA from the feature branch and this PR ports those GA feedback into main while keeping existing preview features intact.
GA PR: #53042