Remove invalid error check from PersistentAgentsChatClient #53017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check is overly strict; it assumes all of the provided messages are in response to a previous conversation with this service, but the messages could be the history from a conversation with another service, as can happen in agent-based scenarios. In such cases, there may be function tool calls and results in the history; the rest of the implementation will properly ignore them, as the service doesn't provide any way to send those calls into the service, but this check was blowing up before then.
stephentoub
requested review from
dargilco,
glharper and
nick863
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes an overly strict validation check in the PersistentAgentsChatClient that was preventing legitimate agent-based conversation scenarios. The removed check incorrectly assumed all messages were from conversations with the same service, but in agent scenarios, message history may include function tool calls from other services that should be allowed and properly ignored by the implementation.
- Removed validation that threw an exception when no thread ID was provided but messages contained tool results
- Updated a comment to be more precise about when tool results are submitted to a run
github-actions
bot
added
AI Model Inference
AI Projects
Community Contribution
|
Thank you for your contribution @stephentoub! We will review the pull request and get back to you soon. |
SergeyMenshykh
approved these changes
Oct 6, 2025
|
@nick863, would you mind reviewing this? |
trrwilson
approved these changes
Oct 22, 2025
nick863
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check is overly strict; it assumes all of the provided messages are in response to a previous conversation with this service, but the messages could be the history from a conversation with another service, as can happen in agent-based scenarios. In such cases, there may be function tool calls and results in the history; the rest of the implementation will properly ignore them, as the service doesn't provide any way to send those calls into the service, but this check was blowing up before then.