Skip to content

Conversation

@omerdolev-ms
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Copilot AI review requested due to automatic review settings June 10, 2025 09:36
@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Jun 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new API version for the HealthBot service, updating the autorest configuration and API surface to accommodate changes in secret management and resource updates.

  • Updates autorest.md with new require link and package tag, and adds a renaming mapping for HealthBot keys.
  • Adds new API methods GetSecrets, RegenerateApiJwtSecret, and updates the Update methods to follow a long-running operation pattern.
  • Updates the model factory and enums by introducing overloads with an additional access control parameter and new enum values.

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

File Description
sdk/healthbot/Azure.ResourceManager.HealthBot/src/autorest.md Updated require link, package tag, and mapping for HealthBot keys.
sdk/healthbot/Azure.ResourceManager.HealthBot/api/Azure.ResourceManager.HealthBot.netstandard2.0.cs Added new secret retrieval and regeneration API members; updated Update method signature and model factory overloads.
sdk/healthbot/Azure.ResourceManager.HealthBot/api/Azure.ResourceManager.HealthBot.net8.0.cs Mirrored changes from netstandard2.0: new secret APIs, Update method updates, and model factory adjustments.
Comments suppressed due to low confidence (4)

sdk/healthbot/Azure.ResourceManager.HealthBot/src/autorest.md:27

  • [nitpick] Consider aligning naming conventions: 'HealthBotKeysResponse' maps to 'HealthBotKeysResult'. Confirm that the naming difference is intentional, or update it for consistency.
  HealthBotKeysResponse: HealthBotKeysResult

sdk/healthbot/Azure.ResourceManager.HealthBot/api/Azure.ResourceManager.HealthBot.netstandard2.0.cs:108

  • Consider adding XML documentation comments for the new 'accessControlMethod' parameter to clarify its intended usage and behavior.
public static Azure.ResourceManager.HealthBot.Models.HealthBotProperties HealthBotProperties(string provisioningState = null, System.Uri botManagementPortalLink = null, Azure.ResourceManager.HealthBot.Models.HealthBotKeyVaultProperties keyVaultProperties = null, string accessControlMethod = null) { throw null; }

sdk/healthbot/Azure.ResourceManager.HealthBot/api/Azure.ResourceManager.HealthBot.netstandard2.0.cs:74

  • The Update method now returns an ArmOperation to support long-running operations; ensure that this breaking change is clearly documented for clients upgrading from the previous API.
public virtual Azure.ResourceManager.ArmOperation<Azure.ResourceManager.HealthBot.HealthBotResource> Update(Azure.WaitUntil waitUntil, Azure.ResourceManager.HealthBot.Models.HealthBotPatch patch, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }

sdk/healthbot/Azure.ResourceManager.HealthBot/api/Azure.ResourceManager.HealthBot.netstandard2.0.cs:192

  • [nitpick] Consider adding XML documentation or inline comments for the new 'PES' enum value to clarify its intended meaning and usage.
PES = 3,

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.ResourceManager.HealthBot

@ArthurMa1978
Copy link
Member

Hey @omerdolev-ms , please help re-record the tests so we can get the CI pipeline green.

@ArthurMa1978
Copy link
Member

Kindly ping @omerdolev-ms

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Hi @omerdolev-ms. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Oct 3, 2025
@github-actions
Copy link

Hi @omerdolev-ms. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Oct 10, 2025
@ArthurMa1978 ArthurMa1978 reopened this Oct 21, 2025
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Oct 21, 2025
@ArthurMa1978
Copy link
Member

@microsoft-github-policy-service rerun

@ArthurMa1978
Copy link
Member

/check-enforcer override

@ArthurMa1978 ArthurMa1978 merged commit 13b0e90 into Azure:main Oct 21, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants