Skip to content

Update LangVersion in individual projects #33890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexanderSher merged 3 commits into from
Feb 3, 2023
Merged

Update LangVersion in individual projects #33890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f83881d
Update LangVersion in individual projects
AlexanderSher Feb 3, 2023
799d7ec
Restore LangVersion tag in sample project
AlexanderSher Feb 3, 2023
2456f88
Address PR comment
AlexanderSher Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/SmokeTests/SmokeTest/SmokeTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFrameworks>net7.0;net6.0;net461</TargetFrameworks>
<LangVersion>latest</LangVersion>
<LangVersion>11.0</LangVersion>
<NoWarn>$(NoWarn);NU1605</NoWarn>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion eng/Directory.Build.Common.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

<!-- Setup default project properties -->
<PropertyGroup>
<LangVersion>11</LangVersion>
<LangVersion>11.0</LangVersion>
<!--
Disable NU5105 NuGet Pack warning that the version is SemVer 2.0.
SemVer 2.0 is supported by NuGet since 3.0.0 (July 2015) in some capacity, and fully since 3.5.0 (October 2016).
Expand Down
1 change: 0 additions & 1 deletion sdk/avs/Microsoft.Azure.Management.Avs/tests/Microsoft.Azure.Management.Avs.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<AssemblyName>Avs.Tests</AssemblyName>
<ExcludeFromBuild>true</ExcludeFromBuild>
<ExcludeFromTest>true</ExcludeFromTest>
<LangVersion>latest</LangVersion>
<TargetFrameworks>net5.0</TargetFrameworks>
</PropertyGroup>
<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion ...isioningServices/tests/Microsoft.Azure.Management.DeviceProvisioningServices.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<AssemblyName>DeviceProvisioningServices.Tests</AssemblyName>
<Version>1.0.0</Version>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<LangVersion>8.0</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion ....Azure.Management.DeviceUpdate/tests/Microsoft.Azure.Management.DeviceUpdate.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<Description>DeviceUpdate.Tests Class Library</Description>
<AssemblyName>Microsoft.Azure.Management.DeviceUpdate.Tests</AssemblyName>
<VersionPrefix>2020-09-01</VersionPrefix>
<LangVersion>latest</LangVersion>
</PropertyGroup>

<PropertyGroup>
Expand Down
1 change: 0 additions & 1 deletion ....Azure.Management.DigitalTwins/tests/Microsoft.Azure.Management.DigitalTwins.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<Description>DigitalTwins.Tests Class Library</Description>
<AssemblyName>DigitalTwins.Tests</AssemblyName>
<VersionPrefix>2022-05-31</VersionPrefix>
<LangVersion>8.0</LangVersion>
</PropertyGroup>

<PropertyGroup>
Expand Down
1 change: 0 additions & 1 deletion ...id/Azure.Messaging.EventGrid/EventGridSourceGenerator/src/EventGridSourceGenerator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<LangVersion>latest</LangVersion>
<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
</PropertyGroup>
<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion .../Azure.Messaging.EventHubs.Processor/perf/Azure.Messaging.EventHubs.Processor.Perf.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<PropertyGroup>
<Version>1.0.0</Version>
<OutputType>Exe</OutputType>
<LangVersion>latest</LangVersion>
<IsTestSupportProject>true</IsTestSupportProject>
</PropertyGroup>

Expand Down
1 change: 0 additions & 1 deletion sdk/eventhub/Azure.Messaging.EventHubs/perf/Azure.Messaging.EventHubs.Perf.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<PropertyGroup>
<Version>1.0.0</Version>
<OutputType>Exe</OutputType>
<LangVersion>latest</LangVersion>
<IsTestSupportProject>true</IsTestSupportProject>
</PropertyGroup>

Expand Down
1 change: 0 additions & 1 deletion sdk/eventhub/Azure.Messaging.EventHubs/stress/src/Azure.Messaging.EventHubs.Stress.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<PropertyGroup>
<Version>1.0.0</Version>
<OutputType>Exe</OutputType>
<LangVersion>latest</LangVersion>
<IsTestSupportProject>true</IsTestSupportProject>
<IsStressProject>false</IsStressProject>
</PropertyGroup>
Expand Down
12 changes: 0 additions & 12 deletions sdk/eventhub/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,4 @@

<!-- Import the common SDK build properties. -->
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory).., Directory.Build.props))\Directory.Build.props" />

<!--
Force the language version in test projects to avoid overload resolution errors for
NUnit assertsions in the RC version of the compiler. This should be fixed with the RC2
release of the .NET 6 SDK. (see: https://github.com/dotnet/roslyn/issues/56167)

Because the common SDK build properties define this value and the intent is to override,
this needs to be set after the common properties import.
-->
<PropertyGroup Condition="$(MSBuildProjectName.StartsWith('Azure.')) and $(MSBuildProjectName.EndsWith('.Tests'))">
<LangVersion>9.0</LangVersion>
</PropertyGroup>
</Project>
1 change: 0 additions & 1 deletion sdk/eventhub/Microsoft.Azure.EventHubs/perf/Microsoft.Azure.EventHubs.Perf.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<PropertyGroup>
<Version>1.0.0</Version>
<OutputType>Exe</OutputType>
<LangVersion>latest</LangVersion>
<IsTestSupportProject>true</IsTestSupportProject>
</PropertyGroup>

Expand Down
1 change: 0 additions & 1 deletion sdk/iothub/Microsoft.Azure.Management.IotHub/src/Microsoft.Azure.Management.IotHub.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

<PropertyGroup>
<TargetFrameworks>$(SdkTargetFx)</TargetFrameworks>
<LangVersion>8.0</LangVersion>
</PropertyGroup>

<PropertyGroup>
Expand Down
1 change: 0 additions & 1 deletion ...ub/Microsoft.Azure.Management.IotHub/tests/Microsoft.Azure.Management.IotHub.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<AssemblyName>IotHub.Tests</AssemblyName>
<Version>1.0.0</Version>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<LangVersion>8.0</LangVersion>
</PropertyGroup>

<PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion sdk/keyvault/samples/keyvaultproxy/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<PropertyGroup>
<RootNamespace>AzureSamples.Security.KeyVault.Proxy</RootNamespace>
<LangVersion>latest</LangVersion>
<LangVersion>11.0</LangVersion>
<NoWarn>
$(NoWarn);
AZC0001
Expand Down
1 change: 0 additions & 1 deletion ...ineLearningServices/tests/Microsoft.Azure.Management.MachineLearningServices.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<Description>MachineLearningServices.Tests Class Library</Description>
<AssemblyName>MachineLearningServices.Tests</AssemblyName>
<VersionPrefix>2020-09-01-preview</VersionPrefix>
<LangVersion>8.0</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion .../Azure.MixedReality.Authentication/shared/Shared.Azure.MixedReality.Authentication.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IsPackable>false</IsPackable>
<LangVersion>latest</LangVersion>
<Nullable>Enable</Nullable>
<AzureCoreSharedSources>$(RepoRoot)/sdk/core/Azure.Core/src/Shared/</AzureCoreSharedSources>
</PropertyGroup>
Expand Down
1 change: 0 additions & 1 deletion sdk/servicebus/Azure.Messaging.ServiceBus/perf/Azure.Messaging.ServiceBus.Perf.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<PropertyGroup>
<Version>1.0.0</Version>
<OutputType>Exe</OutputType>
<LangVersion>latest</LangVersion>
<IsTestSupportProject>true</IsTestSupportProject>
</PropertyGroup>

Expand Down
1 change: 0 additions & 1 deletion ...servicebus/Azure.Messaging.ServiceBus/stress/src/Azure.Messaging.ServiceBus.Stress.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<PropertyGroup>
<Version>1.0.0</Version>
<OutputType>Exe</OutputType>
<LangVersion>latest</LangVersion>
<IsTestSupportProject>true</IsTestSupportProject>
<IsStressProject>false</IsStressProject>
</PropertyGroup>
Expand Down
1 change: 0 additions & 1 deletion ....DataLake/perf/Azure.Storage.Files.DataLake.Perf/Azure.Storage.Files.DataLake.Perf.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<PropertyGroup>
<Version>1.0.0</Version>
<OutputType>Exe</OutputType>
<LangVersion>latest</LangVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 0 additions & 1 deletion ...ft.Azure.Management.StoragePool/tests/Microsoft.Azure.Management.StoragePool.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<AssemblyName>StoragePool.Tests</AssemblyName>
<ExcludeFromBuild>true</ExcludeFromBuild>
<ExcludeFromTest>true</ExcludeFromTest>
<LangVersion>latest</LangVersion>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Azure.Management.ResourceManager" Version="1.6.0-preview" />
Expand Down
1 change: 0 additions & 1 deletion sdk/tables/Azure.Data.Tables/tests/perf/Azure.Data.Tables.Perf.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
<PropertyGroup>
<Version>1.0.0</Version>
<OutputType>Exe</OutputType>
<LangVersion>latest</LangVersion>
<IsTestSupportProject>true</IsTestSupportProject>
</PropertyGroup>

Expand Down