Skip to content

Conversation

@jliusan
Copy link
Member

@jliusan jliusan commented Jun 30, 2025

…generation from spec commit: 86c6306649b02e542117adb46c61e8019dbd78e9
Copilot AI review requested due to automatic review settings June 30, 2025 07:05
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jun 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the armstorageactions SDK for the 1.0.0 release by introducing a breaking change to the update parameters, bumping the module version, and improving generated code validation and examples.

  • Changed StorageTaskUpdateParameters.Properties to the new StorageTaskUpdateProperties type.
  • Added subscription ID validation in request builders and set Content-Type headers.
  • Bumped module version to v1.0.0, updated dependencies, and refreshed example tests and generator comments.

Reviewed Changes

Copilot reviewed 28 out of 29 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsp-location.yaml Added release metadata entry
time_rfc3339.go Updated generated-code comment
storagetasksreport_client.go Added subscriptionID guard and removed duplicate URL replacement
storagetasks_client.go Added Content-Type headers, validation, and changed poller mode
models.go Introduced StorageTaskUpdateProperties and updated type ref
constants.go Bumped moduleVersion to v1.0.0 and enhanced enum docs
go.mod Bumped azcore and other dependencies
CHANGELOG.md Added 1.0.0 release notes
Comments suppressed due to low confidence (4)

sdk/resourcemanager/storageactions/armstorageactions/storagetasksreport_client_example_test.go:21

  • [nitpick] Example code should use a placeholder (e.g., <subscription-id>) instead of a hardcoded GUID to avoid confusion and ensure consistency across samples.
	clientFactory, err := armstorageactions.NewClientFactory("1f31ba14-ce16-4281-b9b4-3e78da6e1616", cred, nil)

sdk/resourcemanager/storageactions/armstorageactions/storagetasks_client_example_test.go:22

  • [nitpick] Use a consistent placeholder (e.g., <subscription-id>) for the subscription ID in examples, rather than embedding a real GUID.
	clientFactory, err := armstorageactions.NewClientFactory("1f31ba14-ce16-4281-b9b4-3e78da6e1616", cred, nil)

sdk/resourcemanager/storageactions/armstorageactions/storagetaskassignment_client_example_test.go:21

  • [nitpick] Replace the hardcoded subscription GUID with a placeholder (e.g., <subscription-id>) to keep sample code generic.
	clientFactory, err := armstorageactions.NewClientFactory("1f31ba14-ce16-4281-b9b4-3e78da6e1616", cred, nil)

sdk/resourcemanager/storageactions/armstorageactions/operations_client_example_test.go:21

  • [nitpick] Use the conventional <subscription-id> placeholder format rather than <subscriptionID> for consistency with other examples.
	clientFactory, err := armstorageactions.NewClientFactory("<subscriptionID>", cred, nil)

@github-actions
Copy link

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/storageactions/armstorageactions

Copy link
Member

@golddove golddove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueww, I validated generated package w/ smoke tests

@blueww blueww merged commit e67c80d into main Jul 3, 2025
16 checks passed
@blueww blueww deleted the release-storageactions-armstorageactions-1.0.0-1751266778 branch July 3, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants