Mahara PR #2 #4657
Merged
Mahara PR #2 #4657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommit b02a6e571dcf8ff5c9c62c8f6b9d7821db4ea5f5
…earlier than 18.04
This reverts commit bbdb989.
darrinhodges
added a commit
to darrinhodges/azure-quickstart-templates
that referenced
this pull request
Jul 20, 2018
darrinhodges
added a commit
to darrinhodges/azure-quickstart-templates
that referenced
this pull request
Jul 20, 2018
bmoore-msft
reviewed
Jul 29, 2018
| "type": "Microsoft.Resources/deployments", | ||
| "apiVersion": "2017-05-10", | ||
| "apiVersion": "2016-09-01", | ||
| "name": "pid-738e3eec-68d4-4667-8377-c05c77c21f1b", |
Collaborator
There was a problem hiding this comment.
@rgardler - is this correct?
|
|
||
| grep "^//$storageAccountName.file.core.windows.net/mahara\s\s*/mahara\s\s*cifs" /etc/fstab | ||
| if [ $? != "0" ]; then | ||
| echo -e "\n//$storageAccountName.file.core.windows.net/mahara /mahara cifs credentials=/etc/mahara_azure_files.credential,uid=www-data,gid=www-data,nofail,vers=3.0,dir_mode=0770,file_mode=0660,serverino,mfsymlinks" >> /etc/fstab |
Collaborator
There was a problem hiding this comment.
Still needs to be addressed
bmoore-msft
requested changes
Jul 29, 2018
| { | ||
| "type": "Microsoft.Resources/deployments", | ||
| "apiVersion": "2016-09-01", | ||
| "name": "pid-738e3eec-68d4-4667-8377-c05c77c21f1b", |
Collaborator
There was a problem hiding this comment.
@rgardler - is this correct?
Contributor
There was a problem hiding this comment.
No, this is not correct. This has been copied from a different template and should be removed from here. Thanks.
| password=$storageAccountKey | ||
| EOF | ||
| chmod 600 /etc/mahara_azure_files.credential | ||
|
|
Collaborator
There was a problem hiding this comment.
still need these hardcoded endpoints fixed...
Contributor
Author
There was a problem hiding this comment.
Yes, I raised an issue about this, please see #4960
Collaborator
|
@rgardler - one comment in here for you... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best Practice Checklist
Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md
For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md
Changelog
The point '"Has anyone run this template sucessfully in production? Yes they have. With that being said we do not make any performance guarantees about this architecture"' has been left in the README.md, should this be removed as part of the PR ?
The content URL for github has been left as the MS Azure links since the previous PR review suggested to update it as such. See #4283 (comment)
Does Mahara come under the banner of a 'managedApplication' or should that reference (and directory) be removed as part of the PR ?
Thanks
Darrin