Cognitive Service Translation API #3748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SychevIgor, |
bmoore-msft
requested changes
Aug 20, 2017
| @@ -0,0 +1,10 @@ | |||
| # Solution name | |||
| "contentVersion": "1.0.0.0", | ||
| "parameters": { | ||
| "AccountsName": { | ||
| "defaultValue": "translate", |
Collaborator
There was a problem hiding this comment.
if this needs to be globally unique, use uniqueString() for the defaultValue
Contributor
Author
There was a problem hiding this comment.
@bmoore-msft no, it could be not globally unique, because it's only visible for you in your subscription.
| "$schema": "http://schema.management.azure.com/schemas/2015-01-01/deploymentParameters.json#", | ||
| "contentVersion": "1.0.0.0", | ||
| "parameters": { | ||
| "SKU": { |
Collaborator
There was a problem hiding this comment.
remove the params since you have defaultValus
Contributor
Author
|
@bmoore-msft could you please again look on PR and my answer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have anything about Cognitive Service Translation API in the repo and it's time to fix it since Cognitive Services are super important part of our strategy