Skip to content

Conversation

@jboeshart
Copy link
Contributor

@jboeshart jboeshart commented Jul 26, 2017

Changed diskSizeGB to not have quotes as it's an integer, and updated the virtual machine resource to use the 2017-03-30 API instead of the preview version it was previously using.

Best Practice Checklist

Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md

  1. uri's compatible with all clouds (Stack, China, Government)
  2. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken
  3. Use resourceGroup().location for resource locations
  4. Folder names for artifacts (nestedtemplates, scripts, DSC)
  5. Use literal values for apiVersion (no variables)
  6. Parameter files (GEN-UNIQUE for value generation and no "changemeplease" values
  7. $schema and other uris use https
  8. Use uniqueString() whenever possible to generate names for resources. While this is not required, it's one of the most common failure points in a deployment.
  9. Update the metadata.json with the current date

For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

Changed diskSizeGB to not have quotes as it's an integer, and updated the virtual machine resource to use the 2017-03-30 API instead of the preview version it was previously using.
@jboeshart jboeshart changed the title Update azuredeploy.json Update 101-vm-simple-windows/azuredeploy.json Jul 26, 2017
@jboeshart
Copy link
Contributor Author

@gatneil can you approve this when you have a chance? I've got a related doc update that leverages this template.

@gatneil
Copy link
Contributor

gatneil commented Aug 7, 2017

Looks good; merging :)

@gatneil gatneil merged commit 8deeb64 into Azure:master Aug 7, 2017
@jboeshart
Copy link
Contributor Author

Thanks @gatneil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants