Skip to content

Conversation

@ejizba
Copy link
Contributor

@ejizba ejizba commented Jan 26, 2017

This spins up a linux vm and a kubernetes cluster. It installs Spinnaker on the vm and configures it to target Kubernetes.

The most complex part is getting the kube config file (used to authenticate) from the kubernetes cluster to the spinnaker vm. I use the service principal and azure cli to give a temp user access to the kubernetes master vms, then scp the file to the spinnaker vm.

Best Practice Checklist

Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md

  1. uri's compatible with all clouds (Stack, China, Government)
  2. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken
  3. Use resourceGroup().location for resource locations
  4. Folder names for artifacts (nestedtemplates, scripts, DSC)
  5. Use literal values for apiVersion (no variables)
  6. Parameter files (GEN-UNIQUE for value generation and no "changemeplease" values
  7. $schema and other uris use https
  8. Use uniqueString() whenever possible to generate names for resources. While this is not required, it's one of the most common failure points in a deployment.
  9. Update the metadata.json with the current date

For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

*Add Spinnaker to Kubernetes template

@azurecla
Copy link

Hi @EricJizbaMSFT, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (erijiz). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

"type": "securestring",
"metadata": {
"description": "The Service Principal Client Secret."
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the extra comma

"vmStorageAccountContainerName": "vhds",
"vmName": "[concat(variables('resourcePrefix'), 'VM')]",
"virtualNetworkName": "[concat(variables('resourcePrefix'), 'VNET')]",
"_artifactsLocation": "https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/spinnaker-vm-to-kubernetes/scripts/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it always be from this repo? is there any use-case that user may want to have his/her own scripts?

This spins up a linux vm and a kubernetes cluster.  It installs Spinnaker on the vm and configures it to target Kubernetes.

The most complex part is getting the kube config file (used to authenticate) from the kubernetes cluster to the spinnaker vm. I use the service principal and azure cli to give a temp user access to the kubernetes master vms, then scp the file to the spinnaker vm.
Copy link
Contributor

@arroyc arroyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arroyc arroyc merged commit c6d71ad into Azure:master Jan 30, 2017
@ejizba ejizba deleted the spink8s branch January 30, 2017 22:46
Copy link
Contributor

@arroyc arroyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants