-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add Spinnaker to Kubernetes template #3002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @EricJizbaMSFT, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
| "type": "securestring", | ||
| "metadata": { | ||
| "description": "The Service Principal Client Secret." | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the extra comma
| "vmStorageAccountContainerName": "vhds", | ||
| "vmName": "[concat(variables('resourcePrefix'), 'VM')]", | ||
| "virtualNetworkName": "[concat(variables('resourcePrefix'), 'VNET')]", | ||
| "_artifactsLocation": "https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/spinnaker-vm-to-kubernetes/scripts/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will it always be from this repo? is there any use-case that user may want to have his/her own scripts?
This spins up a linux vm and a kubernetes cluster. It installs Spinnaker on the vm and configures it to target Kubernetes. The most complex part is getting the kube config file (used to authenticate) from the kubernetes cluster to the spinnaker vm. I use the service principal and azure cli to give a temp user access to the kubernetes master vms, then scp the file to the spinnaker vm.
arroyc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
arroyc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great !
This spins up a linux vm and a kubernetes cluster. It installs Spinnaker on the vm and configures it to target Kubernetes.
The most complex part is getting the kube config file (used to authenticate) from the kubernetes cluster to the spinnaker vm. I use the service principal and azure cli to give a temp user access to the kubernetes master vms, then scp the file to the spinnaker vm.
Best Practice Checklist
Check these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md
For details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md
Changelog
*Add Spinnaker to Kubernetes template