Skip to content

Create slurm cluster #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
singhkays merged 1 commit into from
Jun 4, 2015
Merged

Create slurm cluster #291

singhkays merged 1 commit into from
Jun 4, 2015

Conversation

@YidingZhou
Copy link
Contributor

@YidingZhou YidingZhou commented May 26, 2015

No description provided.

@acomghbot
Copy link

acomghbot commented May 26, 2015

The following issues were detected in this pull request:

Template: slurm

  • The file azuredeploy.json is not valid. Response from ARM API: BadRequest - {"error":{"code":"InvalidTemplate","message":"Deployment template validation failed: 'The template parameters 'publicDomainName' are not valid; they are not present in the original template and can therefore not be provided at deployment time. The only supported parameters for this template are 'dnsName, newStorageAccountName, adminPassword, vmSize, scaleNumber, location, MasterVMName, WorkerVMName, adminUserName'.'."}}

@acomghbot
Copy link

acomghbot commented May 26, 2015

No issues were found in this pull request.

singhkays
singhkays reviewed May 26, 2015
View reviewed changes
slurm/azuredeploy.json Outdated
Copy link
Contributor

@singhkays singhkays May 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelCase for these parameter names

@singhkays
Copy link
Contributor

singhkays commented May 26, 2015

Adding @johngossman for review as well

@acomghbot
Copy link

acomghbot commented May 27, 2015

No issues were found in this pull request.

@YidingZhou
Copy link
Contributor Author

YidingZhou commented May 27, 2015

Updated date and camelCase.

johngossman
johngossman reviewed Jun 2, 2015
View reviewed changes
slurm/azuredeploy.json Outdated
Copy link
Contributor

@johngossman johngossman Jun 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't make this a parameter. Just hardcode "master"

@johngossman
Copy link
Contributor

johngossman commented Jun 2, 2015

Could you please squash your commits?

@acomghbot
Copy link

acomghbot commented Jun 3, 2015

No issues were found in this pull request.

1 similar comment
@acomghbot
Copy link

acomghbot commented Jun 3, 2015

No issues were found in this pull request.

@acomghbot
Copy link

acomghbot commented Jun 3, 2015

The following issues were detected in this pull request:

Template: github-enterprise

  • The 'githubUsername' property in metadata.json does not match the name of the author of the pull request (YidingZhou).

1 similar comment
@acomghbot
Copy link

acomghbot commented Jun 3, 2015

The following issues were detected in this pull request:

Template: github-enterprise

  • The 'githubUsername' property in metadata.json does not match the name of the author of the pull request (YidingZhou).

@YidingZhou
Copy link
Contributor Author

YidingZhou commented Jun 3, 2015

I've squashed the request. How do eliminate the acomghbot comment?

@acomghbot
Copy link

acomghbot commented Jun 3, 2015

No issues were found in this pull request.

Deploy SLURM Cluster using ARM template
44cc17f 
1st commit of creating a slurm cluster

and the post deployment shell script

wrong link to templates

update deployment button

update schema

update api version

update script reference link

update script reference

Update azuredeploy.json

Update azuredeploy.json

Update azuredeploy.json

Update azuredeploy.json

apply new replace() and toLower() functions

replace dots too

Update azuredeploy.json

Update azuredeploy.json

update shell script name

switch to password auth

switch to static IP address

update hosts file before proceeding.

change naming sequence.

Update azuredeploy.sh

Update azuredeploy.json

Update azuredeploy.sh

Update azuredeploy.sh

Update azuredeploy.json

Update azuredeploy.sh

Update comments

add slurm installation part

use double quote for variable expansion when calling sed.

master node is also a compute node. start munged before slurmd.

missed 1 change.

add some debug info

Fix script bugs

push hosts file to worker nodes

bugfix - shell script cli should be quoted.

add parameter template file and update README

minor fix

update according to comments - camelCase and update date.

update according to comments

minor bug fix

Update README.md

revert the change
@acomghbot
Copy link

acomghbot commented Jun 3, 2015

No issues were found in this pull request.

@YidingZhou
Copy link
Contributor Author

YidingZhou commented Jun 3, 2015

Squashed all commits and updated according to comments. #1 VM size, #2 Move VM name from parameters to variables, #3 Co-located username and password parameters, and #4 make parameter json match the deployment template.

singhkays
singhkays reviewed Jun 4, 2015
View reviewed changes
slurm/README.md
Copy link
Contributor

@singhkays singhkays Jun 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated to point to this repo

singhkays pushed a commit that referenced this pull request Jun 4, 2015
Merge pull request #291 from YidingZhou/master
6eb2841 
Create slurm cluster
@singhkays singhkays merged commit 6eb2841 into Azure:master Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YidingZhou @acomghbot @singhkays @johngossman