Added deployment template that installs DNX + scaffolds console app #1974

jochenvw · 2016-05-19T08:27:05Z

Added deployment configuration that deploys an Ubuntu 14.04 box and installs the latest cross platform DNX. After that - a sample console application is scaffolded and built so a 'hello world' from C# .NET code on Linux is a one-liner after deploying the machine.

azurecla · 2016-05-19T08:27:18Z

Hi @jochenvw, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (jowylick). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

jochenvw · 2016-05-20T10:49:20Z

@singhkay Could you please review this PR? Thanks

jochenvw · 2016-05-31T07:24:36Z

@mahthi / @singhkay Could someone please review this PR - would love to see it in master! If you have any feedback, just let me know.

singhkays · 2016-06-01T20:25:29Z

dnx-on-ubuntu/README.md

+
+This template will install the cross platform .NET execution context (DNX) on an Ubuntu Server installation, which allows you to write .NET apps on Linux!
+
+<a href="https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fjochenvw%2Fazure-quickstart-templates%2Fmaster%2Fdnx-on-ubuntu%2Fazuredeploy.json" target="_blank">


The links should point to Azure location

singhkays · 2016-06-01T20:30:20Z

@jochenvw Thanks for creating a template for this unique scenario! Left some comments to address

jochenvw · 2016-06-02T07:27:30Z

@singhkay Awesome - thank you very much for your in-depth review. I'll patch up the code and update the PR. Kudos on maintaining the standards on the templates, I'll step my game up.

- Updated links to point > official azure repo - Removed template comments - Updated parameter names - Moved non-relevant paramaters into variables

singhkays · 2016-06-02T19:30:44Z

@jochenvw Thanks for the update! Can you use camelCase for the parameters and variable names?

jochenvw · 2016-06-02T21:50:15Z

@singhkay Done - but I can't make anything of the Travis build error. Any tips?

AssertionError: Template Validiation Failed. Try deploying your template with the commands:
azure group template validate --resource-group (your_group_name)  --template-file dnx-on-ubuntu/azuredeploy.json --parameters-file dnx-on-ubuntu/azuredeploy.parameters.json
azure group deployment create --resource-group (your_group_name)  --template-file dnx-on-ubuntu/azuredeploy.json --parameters-file dnx-on-ubuntu/azuredeploy.parameters.json 
Server Error:{
    "error": {
        "code": "ENOTFOUND",
        "errno": "ENOTFOUND",
        "syscall": "getaddrinfo",
        "hostname": "arm-validator.40.118.211.57.xip.io"
    }
}

singhkays · 2016-06-02T22:41:23Z

@jochenvw np, that's transient failure with the wildcard dns service xip.io. I've kicked off the build again.

singhkays · 2016-06-02T23:48:57Z

dnx-on-ubuntu/azuredeploy.json

+  "$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#",
+  "contentVersion": "1.0.0.0",
+  "parameters": {
+    "VMAdminPassword": {


this and others below should be vmAdminPassword :)

singhkays · 2016-06-02T23:49:46Z

dnx-on-ubuntu/azuredeploy.json

+    }
+  },
+  "variables": {
+    "NIC name": "dnx-on-ubuntu-nic",


Please rename these variables to camelCase as well. e.g. nsgName

singhkays · 2016-06-02T23:52:46Z

@jochenvw We're good from deployment passing but I'm still seeing some non camel case parameters and variables. Left some comments where updates are needed. Also take a look at some of the existing templates to get an idea of how the parameters and variables are laid out https://github.com/Azure/azure-quickstart-templates/tree/master/201-customscript-extension-public-storage-on-ubuntu

- Replaced 'VM*' by 'vm*' - Camelcased variables - Used prefix notation for variables for DRY-ness - Replaced location by [resourceGroup().location] - Added "autoUpgradeMinorVersion": true, - Removed default username and password

…h rules

jochenvw · 2016-06-13T09:57:04Z

@singhkay I implemented all your feedback, does it look better now?

singhkays · 2016-06-13T17:05:42Z

@jochenvw Thank you for updating! merged

Added deployment template that installs DNX + scaffolds console app

0e869e3

azurecla added the cla-not-required label May 19, 2016

jochenvw added 2 commits May 19, 2016 10:31

Added default value for machine password - required by Travis CI

8659cd9

Added metadata properties to the deployment parameters

6ef6c80

singhkays reviewed Jun 1, 2016
View reviewed changes

jochenvw added 5 commits June 2, 2016 17:21

Implemented code review remaks by @singhkay

c1f4d21

- Updated links to point > official azure repo - Removed template comments - Updated parameter names - Moved non-relevant paramaters into variables

Updated readme.md to point at scripts in official Azure repo

ccb49b7

Build fix: removed trailing comma from JSON template

8e65b08

Build fix: removed trailing comma from params JSON file

58624b6

Build-fix: Fixed JSON-schema validation errors

ce151a2

jochenvw added 2 commits June 2, 2016 23:38

Build-fix + Made parameternames CamelCase

a500105

JSON linter fix - removed trailing comma

90c4fe8

singhkays reviewed Jun 2, 2016
View reviewed changes

jochenvw added 2 commits June 3, 2016 09:37

Build-fix: had to updated default value for password to match strengt…

4551fba

…h rules

Merge remote-tracking branch 'upstream/master'

bcfe340

singhkays merged commit 5be8b13 into Azure:master Jun 13, 2016


		This template will install the cross platform .NET execution context (DNX) on an Ubuntu Server installation, which allows you to write .NET apps on Linux!

		<a href="https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fjochenvw%2Fazure-quickstart-templates%2Fmaster%2Fdnx-on-ubuntu%2Fazuredeploy.json" target="_blank">

Added deployment template that installs DNX + scaffolds console app #1974

Added deployment template that installs DNX + scaffolds console app #1974

Uh oh!

Conversation

jochenvw commented May 19, 2016

Uh oh!

azurecla commented May 19, 2016

Uh oh!

jochenvw commented May 20, 2016

Uh oh!

jochenvw commented May 31, 2016

Uh oh!

singhkays Jun 1, 2016

Choose a reason for hiding this comment

Uh oh!

singhkays commented Jun 1, 2016

Uh oh!

jochenvw commented Jun 2, 2016

Uh oh!

singhkays commented Jun 2, 2016

Uh oh!

jochenvw commented Jun 2, 2016

Uh oh!

singhkays commented Jun 2, 2016

Uh oh!

singhkays Jun 2, 2016

Choose a reason for hiding this comment

Uh oh!

singhkays Jun 2, 2016

Choose a reason for hiding this comment

Uh oh!

singhkays commented Jun 2, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jochenvw commented Jun 13, 2016

Uh oh!

singhkays commented Jun 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

singhkays commented Jun 2, 2016 •

edited

Loading