Skip to content

Azure GameDev VM Solution #12378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmoore-msft merged 71 commits into from
Apr 28, 2022
Merged

Azure GameDev VM Solution #12378

bmoore-msft merged 71 commits into from
Apr 28, 2022

Conversation

@dciborow
Copy link
Contributor

@dciborow dciborow commented Apr 12, 2022

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

@azure-quickstarts azure-quickstarts removed the readme violations README violations during PR label Apr 21, 2022
@ghost ghost removed the needs/author feedback label Apr 26, 2022
@dciborow
Copy link
Contributor Author

dciborow commented Apr 26, 2022

the PreInstall.zip file makes it hard to have visibility into the function (and future changes) - any reason why we can't just add those files/scripts as we did for the others?

Fixed.

@dciborow dciborow requested a review from bmoore-msft April 26, 2022 15:54
@azure-quickstarts azure-quickstarts added the metadata violations metadata violations during PR label Apr 26, 2022
@azure-quickstarts azure-quickstarts removed the metadata violations metadata violations during PR label Apr 26, 2022
@dciborow dciborow requested a review from bmoore-msft April 26, 2022 20:03
@dciborow dciborow requested a review from bmoore-msft April 28, 2022 19:21
@bmoore-msft bmoore-msft merged commit 410b0ab into Azure:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmoore-msft bmoore-msft Awaiting requested review from bmoore-msft

1 more reviewer

@ongk ongk ongk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dciborow @bmoore-msft @ongk @azure-quickstarts