Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Conversation

@jongio
Copy link
Member

@jongio jongio commented Aug 14, 2025

Introduce a command to list repositories in Azure Container Registries, refactor image import logic for better error handling, and enhance the Import-AcrImageAz function with a TargetTag parameter. Improve repository verification logic as well.

Copilot AI review requested due to automatic review settings August 14, 2025 23:09
@jongio jongio requested a review from a team as a code owner August 14, 2025 23:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new command acr registry repository list to list repositories in Azure Container Registries. The implementation includes comprehensive service layer changes, unit and live tests, and infrastructure updates to support repository enumeration across registries.

  • Add repository listing functionality with ACR data-plane client integration
  • Refactor test infrastructure to seed deterministic test data for live testing
  • Enhance error handling and retry logic for image import operations

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
AcrService.cs Implements new ListRegistryRepositories method using Azure.Containers.ContainerRegistry client
RegistryRepositoryListCommand.cs New command class for the repository list functionality
RegistryRepositoryListCommandTests.cs Unit tests covering validation, error handling, and success scenarios
AcrCommandTests.cs Live tests validating repository listing with seeded test data
test-resources-post.ps1 Infrastructure script to seed ACR with deterministic test repository
Directory.Packages.props Adds Azure.Containers.ContainerRegistry package dependency
AcrSetup.cs Registers new repository command group and list command

@jongio jongio requested a review from a team as a code owner August 15, 2025 19:17
@jongio jongio enabled auto-merge (squash) August 15, 2025 21:06
Copy link
Member

@vcolin7 vcolin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add entries for these in docs/azcmp-commands.md and docs/e2eTestPrompts.md.

@github-project-automation github-project-automation bot moved this from Untriaged to In Progress in Azure MCP Server (OLD) Aug 15, 2025
@jongio jongio requested a review from vcolin7 August 15, 2025 23:26
Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xiangyan99 xiangyan99 disabled auto-merge August 16, 2025 00:52
@xiangyan99 xiangyan99 enabled auto-merge (squash) August 16, 2025 00:54
@jongio jongio disabled auto-merge August 16, 2025 02:38
jongio and others added 24 commits August 19, 2025 13:02
@jongio jongio force-pushed the acrregistryrepolist branch from a43a7bb to 1cfde6d Compare August 19, 2025 20:02
@jongio jongio enabled auto-merge (squash) August 19, 2025 20:36
@jongio jongio merged commit 85a8083 into Azure:main Aug 19, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure MCP Server (OLD) Aug 19, 2025
@jongio jongio deleted the acrregistryrepolist branch August 19, 2025 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants