-
Notifications
You must be signed in to change notification settings - Fork 357
Add acr registry repository list
#983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new command acr registry repository list to list repositories in Azure Container Registries. The implementation includes comprehensive service layer changes, unit and live tests, and infrastructure updates to support repository enumeration across registries.
- Add repository listing functionality with ACR data-plane client integration
- Refactor test infrastructure to seed deterministic test data for live testing
- Enhance error handling and retry logic for image import operations
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
AcrService.cs |
Implements new ListRegistryRepositories method using Azure.Containers.ContainerRegistry client |
RegistryRepositoryListCommand.cs |
New command class for the repository list functionality |
RegistryRepositoryListCommandTests.cs |
Unit tests covering validation, error handling, and success scenarios |
AcrCommandTests.cs |
Live tests validating repository listing with seeded test data |
test-resources-post.ps1 |
Infrastructure script to seed ACR with deterministic test repository |
Directory.Packages.props |
Adds Azure.Containers.ContainerRegistry package dependency |
AcrSetup.cs |
Registers new repository command group and list command |
vcolin7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add entries for these in docs/azcmp-commands.md and docs/e2eTestPrompts.md.
conniey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…date related files
Co-authored-by: Copilot <[email protected]>
…og warnings correctly
…date related files
Co-authored-by: Copilot <[email protected]>
…og warnings correctly
…date related files
… enhance error handling
Co-authored-by: Copilot <[email protected]>
…og warnings correctly
Co-authored-by: Copilot <[email protected]>
…og warnings correctly
Co-authored-by: Copilot <[email protected]>
…og warnings correctly
Co-authored-by: Copilot <[email protected]>
…og warnings correctly
Co-authored-by: Copilot <[email protected]>
…og warnings correctly
Co-authored-by: Copilot <[email protected]>
…og warnings correctly
a43a7bb to
1cfde6d
Compare
Introduce a command to list repositories in Azure Container Registries, refactor image import logic for better error handling, and enhance the Import-AcrImageAz function with a TargetTag parameter. Improve repository verification logic as well.