This repository was archived by the owner on Sep 4, 2025. It is now read-only.
Telemetry fixes for ToolName and passing context. #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conniey
requested review from
JonathanCrd,
g2vinay,
hallipr,
jongio,
joshfree,
wbreza and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes telemetry issues by removing duplicate activity tracking and improving MAC address collection for telemetry purposes.
Key changes:
- Removed redundant ToolExecuted activity invocation in McpRuntime
- Enhanced MAC address collection to exclude loopback interfaces and handle null values more robustly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/src/AzureMcp.Core/Extensions/OpenTelemetryExtensions.cs | Improved MAC address collection by filtering out loopback interfaces and providing better null handling |
| core/src/AzureMcp.Core/Areas/Server/Commands/Runtime/McpRuntime.cs | Removed duplicate telemetry activity tracking and simplified CallToolHandler method |
core/src/AzureMcp.Core/Areas/Server/Commands/Runtime/McpRuntime.cs
Outdated
Show resolved
Hide resolved
core/src/AzureMcp.Core/Areas/Server/Commands/Runtime/McpRuntime.cs
Outdated
Show resolved
Hide resolved
anuchandy
approved these changes
Jul 25, 2025
core/src/AzureMcp.Core/Areas/Server/Commands/Runtime/McpRuntime.cs
Outdated
Show resolved
Hide resolved
hallipr
reviewed
Jul 25, 2025
anuchandy
approved these changes
Jul 25, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure MCP Server (OLD)
hallipr
reviewed
Jul 25, 2025
core/src/AzureMcp.Core/Areas/Server/Commands/ToolLoading/CommandFactoryToolLoader.cs
Outdated
Show resolved
Hide resolved
hallipr
reviewed
Jul 25, 2025
conniey
force-pushed
the
update-telemetry-properties
branch
from
3350c3d to
2f9c97c
Compare
conniey
changed the title
anuchandy
approved these changes
Aug 6, 2025
github-project-automation
bot
moved this from In Progress
to Done
in Azure MCP Server (OLD)
chidozieononiwu
pushed a commit
to chidozieononiwu/azure-mcp
that referenced
this pull request
Aug 18, 2025
* Add documentation about handling errors that occur in a loader. * Remove Activity handling inside CommandFactoryToolLoader. * Update McpRuntime to set the Activity status depending on result from calling a tool. * Fix constructor change * Add tests for telemetry. * Update CHANGELOG * Add tests for Tagging ToolName * Pass in command context of current activity if available. * Add current context to cli
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GitHub issue number?
Pre-merge Checklist
CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies).\eng\common\spelling\Invoke-Cspell.ps1README.mddocumentation/docs/azmcp-commands.md/e2eTests/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run azure - mcpto run Live Test Pipeline