This repository was archived by the owner on Sep 4, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 357
Provide azure best practices via server instructions #1007
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Azure best practices content to the server instructions that are provided to LLMs when they interact with the Azure MCP Server. The implementation embeds Azure best practices guidance directly into the server instructions to improve the quality of LLM interactions.
Key changes:
- Added comprehensive server instructions generation with embedded Azure best practices content
- Modified the BestPracticesCommand to load resources from the core assembly for consistency
- Added unit tests to verify the server instructions configuration
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ServiceCollectionExtensions.cs | Added GetServerInstructions() method that generates comprehensive instructions including Azure best practices from embedded resources |
| ServiceCollectionExtensionsTests.cs | Added unit test to verify server instructions are properly configured with expected content |
| BestPracticesCommand.cs | Modified to load embedded resources from the core assembly instead of local assembly |
| CHANGELOG.md | Added entry documenting the new feature |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
core/tests/AzureMcp.Core.UnitTests/Areas/Server/Commands/ServiceCollectionExtensionsTests.cs
Outdated
Show resolved
Hide resolved
core/src/AzureMcp.Core/Areas/Server/Commands/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
core/src/AzureMcp.Core/Areas/Server/Commands/ServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
areas/azurebestpractices/src/AzureMcp.AzureBestPractices/Commands/BestPracticesCommand.cs
Outdated
Show resolved
Hide resolved
jongio
reviewed
Aug 19, 2025
core/src/AzureMcp.Core/Areas/Server/Commands/ServiceCollectionExtensions.cs
Show resolved
Hide resolved
jongio
approved these changes
Aug 19, 2025
jongio
approved these changes
Aug 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provide azure best practices via server instructions. Any clients who honor MCP instructions will get instruction on when to call our bestpractices tools.
For VS Code Copilot agent mode, I've seen these instructions being added to the system prompt

GitHub issue number?
289
Pre-merge Checklist
CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies).\eng\common\spelling\Invoke-Cspell.ps1README.mddocumentation/docs/azmcp-commands.md/docs/e2eTestPrompts.mdeng/tools/ToolDescriptionEvaluatortool and obtained a result >= 0.4crypto mining, spam, data exfiltration, etc.)/azp run azure - mcpto run Live Test Pipeline