Skip to content

Conversation

@vrdmr
Copy link
Member

@vrdmr vrdmr commented Sep 3, 2025

This pull request refactors several Gulp tasks in Build/gulpfile.js to improve error handling and compatibility with newer Gulp versions. It replaces deprecated modules, updates dependencies, and ensures asynchronous tasks handle empty input gracefully. The changes are mainly focused on modernizing the build process and making it more robust.

Dependency and Module Updates

  • Replaced the deprecated request module with Node's built-in https for downloading files, and updated task implementation to handle download errors and file cleanup (gulpfile.js, package.json). [1] [2] [3]
  • Updated the gulp dependency from version 4 to 5 in package.json for improved compatibility and future-proofing.

Task Error Handling and Asynchronous Flow

  • Refactored multiple Gulp tasks (unzip-templates, resources-convert, resources-build, resources-copy, userprompt-copy, zip-output) to accept a done callback and return early when there is no work to do, preventing hanging or unnecessary execution. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Minor Task Callback Consistency

  • Ensured callbacks (cb) are called at the correct locations in build-templates and build-templates-v2 tasks to maintain consistent asynchronous behavior. [1] [2]

@vrdmr vrdmr requested a review from a team as a code owner September 3, 2025 22:04
@manvkaur manvkaur changed the title Fixes for CVE notifications Update gulp Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants