Skip to content

Do not consider abstract classes in configuration options #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinyoo merged 4 commits into from
Feb 22, 2022
Merged

Do not consider abstract classes in configuration options #362

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
912a494
Do not consider abstract classes in configuration options
gsteenpa Feb 14, 2022
8802b33
Update OpenApiConfigurationResolverTests.cs
gsteenpa Feb 15, 2022
4349a10
add fakes
gsteenpa Feb 21, 2022
f2ffe91
remove comment
gsteenpa Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...Microsoft.Azure.WebJobs.Extensions.OpenApi.Core/Resolvers/OpenApiConfigurationResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public static IOpenApiConfigurationOptions Resolve(Assembly assembly)
{
var type = assembly.GetLoadableTypes()
.SingleOrDefault(p => p.GetInterface("IOpenApiConfigurationOptions", ignoreCase: true).IsNullOrDefault() == false
&& p.IsAbstract == false
&& p.GetCustomAttribute<ObsoleteAttribute>(inherit: false).IsNullOrDefault() == true);
if (type.IsNullOrDefault())
{
Expand Down
5 changes: 5 additions & 0 deletions ...zure.WebJobs.Extensions.OpenApi.Core.Tests/Resolvers/OpenApiConfigurationResolverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,10 @@ public void Given_Assembly_When_Resolve_Invoked_Then_It_Should_Return_Result()

result.Should().BeOfType<DefaultOpenApiConfigurationOptions>();
}

// NOTE: this abstract class is referenced via the OpenApiConfigurationResolver.Resolve method (and will be ignored)
public abstract class TestOpenApiConfigurationOptionsBase : DefaultOpenApiConfigurationOptions
{
}
}
}