Skip to content

Conversation

@miloul
Copy link
Contributor

@miloul miloul commented Nov 21, 2021

This PR is add Dictionary test code and modify dictionary object route to dictionaryobject

As the existing integration test case haven't covered the dictionary type, other than dictionary object, the PR wil cover the dictionary type. And modify dictionary object route from dictionary to dictionaryobject. Because dictionary trigger has route that name is dictionary.

@ghost
Copy link

ghost commented Nov 21, 2021

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miloul Thanks for your PR! I left a few comments for you to take further look.

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants