Skip to content

Fix Data Member Attribute json Serialized Model Casing Applied[#212] #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinyoo merged 40 commits into from
Oct 20, 2021
Merged

Fix Data Member Attribute json Serialized Model Casing Applied[#212] #263

justinyoo merged 40 commits into from
Oct 20, 2021

Conversation

@choipureum
Copy link
Contributor

@choipureum choipureum commented Oct 5, 2021

related issue: #212

This PR uses the name by DataMemberAttribute as json serialization namingstrategy like JsonProperty.

  • Before
        [DataMember(Name = "DataMemberValue1")]
        public string DataMemberValue1 { get; set; }
          "dataMemberValue1": {
            "type": "string"
          },
  • After
        [DataMember(Name = "DataMemberValue1")]
        public string DataMemberValue1 { get; set; }
          "DataMemberValue1": {
            "type": "string"
          },

choipureum and others added 30 commits August 24, 2021 00:45
@choipureum
fix Nullable DateTime type to display as date format in specification
d644927 
Signed-off-by: choipureum <[email protected]>
@choipureum
Add a testcase for Nullable DateTime type
961996a 
Signed-off-by: choipureum <[email protected]>
@choipureum
Merge branch 'Azure:main' into main
5318e30
@choipureum
Merge branch 'Azure:main' into main
07bd093
@choipureum
Add DataType Integration Test
cadd264 
Signed-off-by: poo <[email protected]>
@choipureum
Update DateType Integration_Test
ef9d50c 
Signed-off-by: poo <[email protected]>
@choipureum
Modified ContentType for DataType_Integration Test
b0c765d 
Signed-off-by: poo <[email protected]>
@choipureum
Fix tag for DataType Integration Test HttpTrigger
98016f6 
Signed-off-by: poo <[email protected]>
@choipureum
Merge branch 'Azure:main' into main
7386eb7
@choipureum
Merge branch 'Azure:main' into main
6dd4bc5
@choipureum
Merge branch 'Azure:main' into main
3be68b4
@choipureum
Merge branch 'Azure:main' into main
f598263
@choipureum
Adding query string/path Examples
6e35cdd 
Signed-off-by: poo <[email protected]>
@choipureum
Add IntegrationTest : query string/path parameter examples
b1e2a47 
Signed-off-by: poo <[email protected]>
@choipureum
Fix OpenApiParamter Example keyword
a753273 
Signed-off-by: choipureum <[email protected]>
@choipureum
Add string/path Paramter Example Integration Test
ac8eb89 
Signed-off-by: choipureum <[email protected]>
@choipureum
Update ParameterModelExample
82f8b68 
Signed-off-by: choipureum <[email protected]>
@choipureum
Update query string/path Examples
d72ca9e 
Signed-off-by: poo <[email protected]>
@choipureum
Fix Conflict
f0c26b4 
Signed-off-by: poo <[email protected]>
@choipureum
Fix Conflict
1b0c61c
@choipureum
Merge branch 'Azure:main' into main
379cb79
@choipureum
Merge branch 'Azure:main' into main
02ca0f4
@choipureum
Fix query string/path Examples code
067cf84 
Signed-off-by: poo <[email protected]>
@choipureum
Add ParameterExample FakeModel, UnitTest
8fa4915 
Signed-off-by: poo <[email protected]>
@choipureum
Add ParameterExample Integration Tests
b97e380 
Signed-off-by: poo <[email protected]>
@choipureum
Fix OpenApiExampleTests typos
cfe23f0
@choipureum
Merge branch 'Azure:main' into main
7454af6
@choipureum
Add DataTimeOffset type parameter Example
01c7f39 
Signed-off-by: ChoiPuReum <[email protected]>
@choipureum
Merge branch 'Azure:main' into main
5f082e2
@choipureum
Add guid and bytearray type to parameter example function
7c21d6d 
Signed-off-by: ChoiPuReum <[email protected]>
justinyoo
justinyoo suggested changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I've left some comments, mostly for the test cases.

...tegration/Microsoft.Azure.WebJobs.Extensions.OpenApi.TestApp/Models/DataMemberObjectModel.cs Outdated

namespace Microsoft.Azure.WebJobs.Extensions.OpenApi.TestApp.Models
{
public class DataMemberObjectModel
Copy link
Contributor

@justinyoo justinyoo Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create another class/file for JsonPropertyObjectModel for another test?

...tegration/Microsoft.Azure.WebJobs.Extensions.OpenApi.TestApp/Models/DataMemberObjectModel.cs Outdated
{
public class DataMemberObjectModel
{
[DataMember(Name = "DataMemberValue1")]
Copy link
Contributor

@justinyoo justinyoo Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're testing the property naming, can we set these property names in some weird ways like DAtAmeMBervALue1 so that it's rendered as expected?

Copy link
Contributor Author

@choipureum choipureum Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a variety of things.Thank you always for the reviews! 😊

...Azure.WebJobs.Extensions.OpenApi.TestApp/Get_ApplicationJson_DataMemberObject_HttpTrigger.cs Outdated

namespace Microsoft.Azure.WebJobs.Extensions.OpenApi.TestApp
{
public static class Get_ApplicationJson_DataMemberObject_HttpTrigger
Copy link
Contributor

@justinyoo justinyoo Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create another one for Get_ApplicationJson_JsonPropertyObject_HttpTrigger?

...soft.Azure.WebJobs.Extensions.OpenApi.Document.Tests/Get_ApplicationJson_DataMember_Tests.cs Outdated
{
[TestClass]
[TestCategory(Constants.TestCategory)]
public class Get_ApplicationJson_DataMember_Tests
Copy link
Contributor

@justinyoo justinyoo Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create another test class, Get_ApplicationJson_JsonProperty_Tests?

@choipureum choipureum requested a review from justinyoo October 12, 2021 23:52
@justinyoo justinyoo added oca-issue bug Something isn't working labels Oct 16, 2021
justinyoo
justinyoo approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@justinyoo justinyoo merged commit 4b37b9e into Azure:main Oct 20, 2021
@justinyoo justinyoo linked an issue Nov 5, 2021 that may be closed by this pull request
Swagger Payload ignores [DataMember] name changes for json serialization. #212
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@justinyoo justinyoo justinyoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Swagger Payload ignores [DataMember] name changes for json serialization.

2 participants

@choipureum @justinyoo