Updates to support Durable Client feature #1566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorMcMahon
suggested changes
Nov 19, 2020
Contributor
ConnorMcMahon
left a comment
ConnorMcMahon
left a comment
There was a problem hiding this comment.
I think the current iteration will break clients used by Durable Functions apps.
src/WebJobs.Extensions.DurableTask/ContextImplementations/DurableClient.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Extensions.DurableTask/ContextImplementations/DurableClient.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Extensions.DurableTask/ContextImplementations/DurableClientFactory.cs
Show resolved
Hide resolved
ConnorMcMahon
approved these changes
Nov 20, 2020
Contributor
ConnorMcMahon
left a comment
ConnorMcMahon
left a comment
There was a problem hiding this comment.
I have a small nit regarding test names, but overall I think this is ready, at least for initial release!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are for the new Durable Client feature (#1125). With the new feature, there isn't a way to create the HTTP management payloads from the lack of a webhook URL so exceptions are thrown when a user tries to call
CreateCheckStatusResponseorCreateHttpManagementPayload.