-
Notifications
You must be signed in to change notification settings - Fork 201
WriteAsJsonAsync always return status code OK bug fixes #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@emrekara37 thank you for the PR! As is, this PR introduces a behavior change that could be breaking for customer relying on the existing functionality (typically, these kinds of behavior changes are not made in a minor version). An option to address this is to introduce an overload that takes the status code as an additional argument, keeping the default as-is for backwards compatibility. Thoughts? |
Hi @fabiocav i think you're right, i can implement overload version if you want |
|
@emrekara37 if you're open to that, absolutely! That would be great! |
I updated the PR |
fabiocav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Small nit comments.
Hi @fabiocav, |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thank you! |
|
Thanks for resolving #344! ✨ |
Hi @fabiocav , @ankitkumarr
Can you review it when you have time ?
Resolves #344